#26426 fixed#28715
Conversation
# Conflicts: # .jenkins/caffe2/build.sh
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
houseroad
left a comment
There was a problem hiding this comment.
I will create another PR to test the code, if it is okay, i will merge this one.
|
sure :) |
|
Some CI won't be trigger here, so I have to explicitly trigger it. |
|
The build still fails. Check #28720 |
|
@houseroad I didn't know that you keep TRT5 permanently installed on your CI boxes. It's incompatible with TRT6. Is this OK to return TRT6 installer back to my PR? Just installer, no CI integration. |
|
@drnikolaev do you mean here: https://github.com/pytorch/pytorch/blob/master/.jenkins/caffe2/build.sh#L133 If so, feel free to update it. |
|
@houseroad Yes but let's keep it simple. New parser needs TRT6, so why bother? If no TRT6 installed, turn the feature off and issue a warning. |
|
@houseroad I tried to clone your branch here: #28737 but still can't see |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Seems good. Let me do one more check. |
Summary: This is the fix for reverted pytorch/pytorch#26426 houseroad bddppq soumith Pull Request resolved: pytorch/pytorch#28715 Reviewed By: hl475 Differential Revision: D18146731 Pulled By: houseroad fbshipit-source-id: 247366451a6334e84df82d00339521f797b33130
|
@houseroad merged this pull request in 1e2049c. |
This is the fix for reverted #26426
@houseroad @bddppq @soumith