Fix the level of headers in pytorch/CONTRIBUTING.md#28412

Closed

jokerkeny wants to merge 2 commits intopytorch:masterfrom

jokerkeny:patch-1

Contributor

jokerkeny commented Oct 22, 2019

Running Clang-Tidy, Pre-commit Tidy/Linting Hook, Building PyTorch with ASAN shouldn't belong to Windows development tips.


          Fix the level of headers

ee186e5

Running Clang-Tidy、Pre-commit Tidy/Linting Hook、Building PyTorch with ASAN shouldn't belong to Windows development tips

jokerkeny changed the title ~~Fix the level of headers~~ Fix the level of headers in pytorch/CONTRIBUTING.md

pytorchbot added the open source label

ezyang approved these changes

View reviewed changes


          Merge remote-tracking branch 'origin/master' into patch-1

357b5b5

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Member

kostmo commented Feb 3, 2020

💊 CircleCI build failures summary and remediations

As of commit 357b5b5:

5/5 failures introduced in this PR

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

🕵️ 5 new failures recognized by patterns

The following build failures do not appear to be due to upstream breakage:

pytorch_linux_xenial_py3_5_build (1/5)

Step: "Should run job" (full log | pattern match details)

/home/circleci/workspace/.circleci/scripts/should_run_job.sh: line 25: circleci: command not found

+ '[' -z pytorch-linux-xenial-py3.5-build ']' 
+ '[' -e /home/circleci/workspace/.circleci/scripts/COMMIT_MSG ']' 
+ '[' -n https://github.com/pytorch/pytorch/pull/28412 ']' 
+ [[ pull/28412 != \c\i\-\a\l\l\/* ]] 
+ [[ pull/28412 != \n\i\g\h\t\l\y ]] 
+ [[ pull/28412 != \p\o\s\t\n\i\g\h\t\l\y ]] 
+ '[' -e /home/circleci/workspace/.circleci/scripts/should_run_job.py ']' 
+ python /home/circleci/workspace/.circleci/scripts/should_run_job.py pytorch-linux-xenial-py3.5-build 
Rejecting pytorch-linux-xenial-py3.5-build 
+ circleci step halt 
/home/circleci/workspace/.circleci/scripts/should_run_job.sh: line 25: circleci: command not found

pytorch_parallelnative_linux_xenial_py3_6_gcc5_4_build (2/5)

Step: "Should run job" (full log | pattern match details)

/home/circleci/workspace/.circleci/scripts/should_run_job.sh: line 25: circleci: command not found

+ '[' -z pytorch-parallelnative-linux-xenial-py3.6-gcc5.4-build ']' 
+ '[' -e /home/circleci/workspace/.circleci/scripts/COMMIT_MSG ']' 
+ '[' -n https://github.com/pytorch/pytorch/pull/28412 ']' 
+ [[ pull/28412 != \c\i\-\a\l\l\/* ]] 
+ [[ pull/28412 != \n\i\g\h\t\l\y ]] 
+ [[ pull/28412 != \p\o\s\t\n\i\g\h\t\l\y ]] 
+ '[' -e /home/circleci/workspace/.circleci/scripts/should_run_job.py ']' 
+ python /home/circleci/workspace/.circleci/scripts/should_run_job.py pytorch-parallelnative-linux-xenial-py3.6-gcc5.4-build 
Rejecting pytorch-parallelnative-linux-xenial-py3.6-gcc5.4-build 
+ circleci step halt 
/home/circleci/workspace/.circleci/scripts/should_run_job.sh: line 25: circleci: command not found

pytorch_paralleltbb_linux_xenial_py3_6_gcc5_4_build (3/5)

Step: "Should run job" (full log | pattern match details)

/home/circleci/workspace/.circleci/scripts/should_run_job.sh: line 25: circleci: command not found

+ '[' -z pytorch-paralleltbb-linux-xenial-py3.6-gcc5.4-build ']' 
+ '[' -e /home/circleci/workspace/.circleci/scripts/COMMIT_MSG ']' 
+ '[' -n https://github.com/pytorch/pytorch/pull/28412 ']' 
+ [[ pull/28412 != \c\i\-\a\l\l\/* ]] 
+ [[ pull/28412 != \n\i\g\h\t\l\y ]] 
+ [[ pull/28412 != \p\o\s\t\n\i\g\h\t\l\y ]] 
+ '[' -e /home/circleci/workspace/.circleci/scripts/should_run_job.py ']' 
+ python /home/circleci/workspace/.circleci/scripts/should_run_job.py pytorch-paralleltbb-linux-xenial-py3.6-gcc5.4-build 
Rejecting pytorch-paralleltbb-linux-xenial-py3.6-gcc5.4-build 
+ circleci step halt 
/home/circleci/workspace/.circleci/scripts/should_run_job.sh: line 25: circleci: command not found

binary_linux_manywheel_3_7m_cu100_devtoolset7_test (4/5)

Step: "Should run job" (full log | pattern match details)

/home/circleci/workspace/.circleci/scripts/should_run_job.sh: line 25: circleci: command not found

+ '[' -z 'manywheel 3.7m cu100 devtoolset7' ']' 
+ '[' -e /home/circleci/workspace/.circleci/scripts/COMMIT_MSG ']' 
+ '[' -n https://github.com/pytorch/pytorch/pull/28412 ']' 
+ [[ pull/28412 != \c\i\-\a\l\l\/* ]] 
+ [[ pull/28412 != \n\i\g\h\t\l\y ]] 
+ [[ pull/28412 != \p\o\s\t\n\i\g\h\t\l\y ]] 
+ '[' -e /home/circleci/workspace/.circleci/scripts/should_run_job.py ']' 
+ python /home/circleci/workspace/.circleci/scripts/should_run_job.py 'manywheel 3.7m cu100 devtoolset7' 
Rejecting manywheel 3.7m cu100 devtoolset7 
+ circleci step halt 
/home/circleci/workspace/.circleci/scripts/should_run_job.sh: line 25: circleci: command not found

binary_linux_conda_2_7_cpu_devtoolset7_test (5/5)

Step: "Should run job" (full log | pattern match details)

/home/circleci/workspace/.circleci/scripts/should_run_job.sh: line 25: circleci: command not found

+ '[' -z 'conda 2.7 cpu devtoolset7' ']' 
+ '[' -e /home/circleci/workspace/.circleci/scripts/COMMIT_MSG ']' 
+ '[' -n https://github.com/pytorch/pytorch/pull/28412 ']' 
+ [[ pull/28412 != \c\i\-\a\l\l\/* ]] 
+ [[ pull/28412 != \n\i\g\h\t\l\y ]] 
+ [[ pull/28412 != \p\o\s\t\n\i\g\h\t\l\y ]] 
+ '[' -e /home/circleci/workspace/.circleci/scripts/should_run_job.py ']' 
+ python /home/circleci/workspace/.circleci/scripts/should_run_job.py 'conda 2.7 cpu devtoolset7' 
Rejecting conda 2.7 cpu devtoolset7 
+ circleci step halt 
/home/circleci/workspace/.circleci/scripts/should_run_job.sh: line 25: circleci: command not found

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

facebook-github-bot closed this in

48eff08

facebook-github-bot added the merged label

Contributor

facebook-github-bot commented Feb 3, 2020

@ezyang merged this pull request in 48eff08.

BowenBao pushed a commit to BowenBao/pytorch that referenced this pull request


          Fix the level of headers in pytorch/CONTRIBUTING.md (pytorch#28412)

23c5fad

Summary:
**Running Clang-Tidy**, **Pre-commit Tidy/Linting Hook**, **Building PyTorch with ASAN** shouldn't belong to **Windows development tips**.
Pull Request resolved: pytorch#28412

Differential Revision: D19700228

Pulled By: ezyang

fbshipit-source-id: 39d999c68e4bd9264f4ae1fdab517871c883a663

ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request


          Fix the level of headers in pytorch/CONTRIBUTING.md (pytorch#28412)

bc85cd8

Summary:
**Running Clang-Tidy**, **Pre-commit Tidy/Linting Hook**, **Building PyTorch with ASAN** shouldn't belong to **Windows development tips**.
Pull Request resolved: pytorch#28412

Differential Revision: D19700228

Pulled By: ezyang

fbshipit-source-id: 39d999c68e4bd9264f4ae1fdab517871c883a663

mruberry added the Merged label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged open source