[pytorch] change detach() & detach_() to no-op for USE_STATIC_DISPATCH mode#28400
Closed
ljk53 wants to merge 1 commit intogh/ljk53/67/basefrom
Closed
[pytorch] change detach() & detach_() to no-op for USE_STATIC_DISPATCH mode#28400ljk53 wants to merge 1 commit intogh/ljk53/67/basefrom
ljk53 wants to merge 1 commit intogh/ljk53/67/basefrom
Conversation
…H mode Summary: This is yet-another fix to issue #26764. Some mobile models call tensor.detach() which won't work with static-dispatch mode. We disable autograd for static-dispatch / mobile build anyway so it seems fine to make these op-ops. Test Plan: - With stacked PRs, confirmed it can run failed models now. [ghstack-poisoned]
This was referenced Oct 22, 2019
ljk53
added a commit
that referenced
this pull request
Oct 22, 2019
…H mode Summary: This is yet-another fix to issue #26764. Some mobile models call tensor.detach() which won't work with static-dispatch mode. We disable autograd for static-dispatch / mobile build anyway so it seems fine to make these op-ops. Test Plan: - With stacked PRs, confirmed it can run failed models now. ghstack-source-id: d73ec06 Pull Request resolved: #28400
ezyang
approved these changes
Oct 22, 2019
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 22, 2019
…8400) Summary: Pull Request resolved: pytorch/pytorch#28400 This is yet-another fix to issue #26764. Some mobile models call tensor.detach() which won't work with static-dispatch mode. We disable autograd for static-dispatch / mobile build anyway so it seems fine to make these op-ops. Test Plan: - With stacked PRs, confirmed it can run failed models now. Differential Revision: D18055852 Pulled By: ljk53 fbshipit-source-id: bff3a55fee2ca68ac5333fb4978c11fd18dfcc91
Contributor
|
so, what's the plan for addressing this when STATIC_DISPATCH goes away? |
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
…torch#28400) Summary: Pull Request resolved: pytorch#28400 This is yet-another fix to issue pytorch#26764. Some mobile models call tensor.detach() which won't work with static-dispatch mode. We disable autograd for static-dispatch / mobile build anyway so it seems fine to make these op-ops. Test Plan: - With stacked PRs, confirmed it can run failed models now. Differential Revision: D18055852 Pulled By: ljk53 fbshipit-source-id: bff3a55fee2ca68ac5333fb4978c11fd18dfcc91
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This is yet-another fix to issue #26764.
Some mobile models call tensor.detach() which won't work with
static-dispatch mode. We disable autograd for static-dispatch / mobile
build anyway so it seems fine to make these op-ops.
Test Plan:
Differential Revision: D18055852