Disable tsan for test_c10d multiprocess test cases.#28385
Closed
pritamdamania87 wants to merge 1 commit intogh/pritamdamania87/17/basefrom
Closed
Disable tsan for test_c10d multiprocess test cases.#28385pritamdamania87 wants to merge 1 commit intogh/pritamdamania87/17/basefrom
pritamdamania87 wants to merge 1 commit intogh/pritamdamania87/17/basefrom
Conversation
TSAN doesn't work with multiprocessing with fork() since we end up forking in a multithreaded environment which is dangerous. As a result, I'm disabling TSAN in this change. Similar to #27410 and #25005 Differential Revision: [D18047778](https://our.internmc.facebook.com/intern/diff/D18047778/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Oct 21, 2019
TSAN doesn't work with multiprocessing with fork() since we end up forking in a multithreaded environment which is dangerous. As a result, I'm disabling TSAN in this change. Similar to #27410 and #25005 Differential Revision: [D18047778](https://our.internmc.facebook.com/intern/diff/D18047778/) ghstack-source-id: 92319347 Pull Request resolved: #28385
xush6528
approved these changes
Oct 21, 2019
mrshenli
approved these changes
Oct 21, 2019
Contributor
|
This pull request has been merged in 6335d91. |
Contributor
|
This pull request has been merged in 6335d91. |
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#28385 TSAN doesn't work with multiprocessing with fork() since we end up forking in a multithreaded environment which is dangerous. As a result, I'm disabling TSAN in this change. Similar to pytorch#27410 and pytorch#25005 ghstack-source-id: 92319347 Test Plan: waitforbuildbot Differential Revision: D18047778 fbshipit-source-id: 6c4e251639f74f4c772bd09bc6f2dfa83cf18fad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
TSAN doesn't work with multiprocessing with fork() since we end up
forking in a multithreaded environment which is dangerous. As a result, I'm
disabling TSAN in this change.
Similar to #27410 and
#25005
Differential Revision: D18047778