Note: This PR changes add/sub/mul but not div. Div was in a separate PR:
#25968

looks like this still has valid test failures?

FAIL: test_doc_examples (main.TestTypeHints)

Looks like add and sub should no longer be an exception when generating type hints. I've removed them from the exception list and the type hint tests can pass now.

@nairbv My experiment shows that, when I call torch.add(a, 2) (where a=torch.ones(10)), the entry seems to be

Tensor add(const Tensor& self, const Tensor& other, Scalar alpha)

That means, the following scalar version function is not called:

Tensor add(const Tensor& self, Scalar other, Scalar alpha)

But torch.pow(a, 2) will call the scalar version of pow:

Tensor pow(const Tensor& base, Scalar exp)

Do you have any idea why this is happening?

@nairbv My experiment shows that, when I call torch.add(a, 2) (where a=torch.ones(10)), the entry seems to be

Tensor add(const Tensor& self, const Tensor& other, Scalar alpha)

That means, the following scalar version function is not called:

Tensor add(const Tensor& self, Scalar other, Scalar alpha)

But torch.pow(a, 2) will call the scalar version of pow:

Tensor pow(const Tensor& base, Scalar exp)

Do you have any idea why this is happening?

It's confusing, but I'm guessing it's related to the deprecated function add(Tensor self, Scalar alpha, Tensor other)

see ./tools/autograd/deprecated.yaml

e.g. here I can make it complain about 'alpha' when it's the second arg that's floating point:

>>> torch.add(2, 1.5, 1)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
RuntimeError: For integral input tensors, argument alpha must not be a floating point number.

I've got an answer from @ailzhang , sort of make sense to me: #28534 (comment)

The CI failure is blocked by #29238

Hi @xuhdev!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
Stale pull requests will automatically be closed 30 days after being marked Stale

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.