Clarify that when the divisor in div is zero and the dividend is integral, the behavior is undefined.#25968
Closed
xuhdev wants to merge 1 commit intopytorch:masterfrom
Closed
Clarify that when the divisor in div is zero and the dividend is integral, the behavior is undefined.#25968xuhdev wants to merge 1 commit intopytorch:masterfrom
xuhdev wants to merge 1 commit intopytorch:masterfrom
Conversation
gchanan
reviewed
Sep 12, 2019
Contributor
gchanan
left a comment
There was a problem hiding this comment.
On the current master documentation, input and out don't display correct -- can you fix that if possible?
gchanan
reviewed
Sep 12, 2019
Collaborator
Author
Do you mean replacing |
Contributor
|
@nairbv can you take over reviewing this? |
Closed
382f54a to
9c1dbdd
Compare
nairbv
reviewed
Oct 11, 2019
…gral, the behavior is undefined. Currently when an integral tensor is divided by zero, it emits a "floating point exception" (which can be different from system to system). Clarify in the document that nothing would be guaranteed under this circumstance.
nairbv
approved these changes
Oct 11, 2019
Collaborator
Author
|
@pytorchbot merge this please |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
…gral, the behavior is undefined. (pytorch#25968) Summary: Currently when an integral tensor is divided by zero, it emits a "floating point exception" (which can be different from system to system). Clarify in the document that nothing would be guaranteed under this circumstance. Pull Request resolved: pytorch#25968 Differential Revision: D17888097 Pulled By: ezyang fbshipit-source-id: 7c3ce3ac4080479d637cc2710b6aa3ae7e42431d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when an integral tensor is divided by zero, it emits a
"floating point exception" (which can be different from system to
system). Clarify in the document that nothing would be guaranteed under
this circumstance.