provide memory format as Contiguous explicitly when calling to clone()#28029
provide memory format as Contiguous explicitly when calling to clone()#28029ifedan wants to merge 17 commits intopytorch:masterfrom
Conversation
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
VitalyFedyunin
left a comment
There was a problem hiding this comment.
Everything looks good except one questionable update.
|
|
||
| auto memory_format = | ||
| optional_memory_format.value_or(MemoryFormat::Contiguous); | ||
| optional_memory_format.value_or(MemoryFormat::Preserve); |
There was a problem hiding this comment.
Sure it is right to change the intend?
There was a problem hiding this comment.
I removed it from this PR
VitalyFedyunin
left a comment
There was a problem hiding this comment.
Discussed in-person.
…m/ifedan/pytorch into clone_with_memory_format_preserve
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…) (#28029) Summary: provide memory format explicitly when calling to clone(): ``` clone(MemoryFormat::Contiguous); \\instead of clone() ``` This change is based on pytorch/pytorch#27106 Pull Request resolved: pytorch/pytorch#28029 Differential Revision: D17937468 Pulled By: ifedan fbshipit-source-id: 0a6a600af76fc616f88893e5db16aabd7981ce14
provide memory format explicitly when calling to clone():
This change is based on #27106