Skip to content

raise when jit-load.ing a folder#27836

Closed
fenollp wants to merge 1 commit intopytorch:masterfrom
fenollp:err-dir
Closed

raise when jit-load.ing a folder#27836
fenollp wants to merge 1 commit intopytorch:masterfrom
fenollp:err-dir

Conversation

@fenollp
Copy link
Contributor

@fenollp fenollp commented Oct 14, 2019

Very similar to #16267 but handling directories.

Stoked to contribute!

@fenollp fenollp requested a review from apaszke as a code owner October 14, 2019 08:32
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Oct 14, 2019
@fenollp
Copy link
Contributor Author

fenollp commented Oct 14, 2019

Sorry @apaszke I'm not sure I requested your review. Maybe it was automatic? or it's my mistake :)

Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 37953d9.

@fenollp fenollp deleted the err-dir branch February 3, 2020 19:47
BowenBao pushed a commit to BowenBao/pytorch that referenced this pull request Feb 12, 2020
Summary:
Very similar to pytorch#16267 but handling directories.

Stoked to contribute!
Pull Request resolved: pytorch#27836

Differential Revision: D19698398

Pulled By: ezyang

fbshipit-source-id: eabc3a44d258124f860babb47ab91e22c2c3d6cc
ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
Summary:
Very similar to pytorch#16267 but handling directories.

Stoked to contribute!
Pull Request resolved: pytorch#27836

Differential Revision: D19698398

Pulled By: ezyang

fbshipit-source-id: eabc3a44d258124f860babb47ab91e22c2c3d6cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants