Removes @default_floating_dtype decorator#27628
Closed
Conversation
…ial_default_dtype_removal
albanD
approved these changes
Oct 9, 2019
Collaborator
Author
|
@pytorchbot rebase this please. |
Collaborator
Author
|
@pytorchbot rebase this please. |
Collaborator
Author
|
@pytorchbot rebase this please. |
Collaborator
Author
|
@pytorchbot rebase this please. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
nairbv
reviewed
Nov 27, 2019
| check_len(DataLoader(self.dataset, batch_size=2), 50) | ||
| check_len(DataLoader(self.dataset, batch_size=3), 34) | ||
|
|
||
| # FIXME: conversion from np.float64 to torch.DoubleTensor does not work |
Collaborator
Collaborator
Author
There was a problem hiding this comment.
@nairbv cool! I couldn't find an issue for this, although I thought we had one filed. If I come across it I'll let you know.
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: One fewer legacy decorator cluttering the test suite. Functions relying on this decorator were updated or, in the case of test_sparse, the test suite was put back on double by default. Note: this PR is blocked on pytorch#27599. Pull Request resolved: pytorch#27628 Differential Revision: D17896254 Pulled By: mruberry fbshipit-source-id: 13d460301f50ef4af7a660372432108164c0de1f
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: One fewer legacy decorator cluttering the test suite. Functions relying on this decorator were updated or, in the case of test_sparse, the test suite was put back on double by default. Note: this PR is blocked on pytorch#27599. Pull Request resolved: pytorch#27628 Differential Revision: D17896254 Pulled By: mruberry fbshipit-source-id: 13d460301f50ef4af7a660372432108164c0de1f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One fewer legacy decorator cluttering the test suite.
Functions relying on this decorator were updated or, in the case of test_sparse, the test suite was put back on double by default.
Note: this PR is blocked on #27599.