Skip to content

Modify PyTorch's integration of NNPACK to use a unified underlying thread pool implementation.#27496

Closed
AshkanAliabadi wants to merge 1 commit intopytorch:v1.3.0from
AshkanAliabadi:optimize
Closed

Modify PyTorch's integration of NNPACK to use a unified underlying thread pool implementation.#27496
AshkanAliabadi wants to merge 1 commit intopytorch:v1.3.0from
AshkanAliabadi:optimize

Conversation

@AshkanAliabadi
Copy link
Contributor

Same as #27341 but against v1.3.0.

@AshkanAliabadi AshkanAliabadi added this to the 1.3 milestone Oct 7, 2019
@AshkanAliabadi AshkanAliabadi requested a review from ljk53 October 7, 2019 22:01
@soumith
Copy link
Collaborator

soumith commented Oct 8, 2019

this is failing CI with legit failures.

Rebased it for good measure, but rebase is not going to fix them afaics.

Example failures:

Oct 07 23:58:57 ERROR: test_nnpack_conv (__main__.TestNN)
Oct 07 23:58:57 ----------------------------------------------------------------------
Oct 07 23:58:57 Traceback (most recent call last):
Oct 07 23:58:57   File "test_nn.py", line 8591, in test_nnpack_conv
Oct 07 23:58:57     output = torch._nnpack_spatial_convolution(input, weight, stride=stride, padding=padding, bias=bias)
Oct 07 23:58:57 TypeError: _nnpack_spatial_convolution() got an unexpected keyword argument 'stride'
Oct 07 23:58:57 
Oct 07 23:58:57 ----------------------------------------------------------------------
Oct 07 23:58:57 Ran 1472 tests in 594.213s
Oct 07 23:58:34 ======================================================================
Oct 07 23:58:34 ERROR: test_nnpack_conv (__main__.TestNN)
Oct 07 23:58:34 ----------------------------------------------------------------------
Oct 07 23:58:34 Traceback (most recent call last):
Oct 07 23:58:34   File "test_nn.py", line 8591, in test_nnpack_conv
Oct 07 23:58:34     output = torch._nnpack_spatial_convolution(input, weight, stride=stride, padding=padding, bias=bias)
Oct 07 23:58:34 TypeError: _nnpack_spatial_convolution() got an unexpected keyword argument 'stride'
Oct 07 23:58:34 
Oct 07 23:58:34 ----------------------------------------------------------------------

@AshkanAliabadi
Copy link
Contributor Author

Merged in #27547.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: nn Related to torch.nn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants