Modify PyTorch's integration of NNPACK to use a unified underlying thread pool implementation.#27341
Closed
AshkanAliabadi wants to merge 5 commits intogh/AshkanAliabadi/2/basefrom
Closed
Modify PyTorch's integration of NNPACK to use a unified underlying thread pool implementation.#27341AshkanAliabadi wants to merge 5 commits intogh/AshkanAliabadi/2/basefrom
AshkanAliabadi wants to merge 5 commits intogh/AshkanAliabadi/2/basefrom
Conversation
…read pool implementation. [ghstack-poisoned]
ljk53
reviewed
Oct 4, 2019
Contributor
ljk53
left a comment
There was a problem hiding this comment.
Thanks for discovering and fixing this problem!
added 2 commits
October 4, 2019 12:14
…derlying thread pool implementation." Multi-threaded: ``` Pixel 2: Before: 362.716 PR-27340: 185.799 PR-27341: 142.011 Pixel 3: Before: 246.755 PR-27340: 160.045 PR-27341: 115.437 ``` Single-threaded: ``` Pixel 2: Before: 308.084 PR-27340: 303.539 PR-27341: 313.558 Pixel 3: Before: 234.272 PR-27340: 227.158 PR-27341: 232.787 ``` [ghstack-poisoned]
…derlying thread pool implementation." Multi-threaded: ``` Pixel 2: Before: 362.716 PR-27340: 185.799 PR-27341: 142.011 Pixel 3: Before: 246.755 PR-27340: 160.045 PR-27341: 115.437 ``` Single-threaded: ``` Pixel 2: Before: 308.084 PR-27340: 303.539 PR-27341: 313.558 Pixel 3: Before: 234.272 PR-27340: 227.158 PR-27341: 232.787 ``` [ghstack-poisoned]
ljk53
approved these changes
Oct 5, 2019
…derlying thread pool implementation." Multi-threaded: ``` Pixel 2: Before: 362.716 PR-27402: 185.799 PR-27341: 142.011 Pixel 3: Before: 246.755 PR-27402: 160.045 PR-27341: 115.437 ``` Single-threaded: ``` Pixel 2: Before: 308.084 PR-27340: 303.539 PR-27341: 313.558 Pixel 3: Before: 234.272 PR-27340: 227.158 PR-27341: 232.787 ``` [ghstack-poisoned]
…derlying thread pool implementation." Multi-threaded: ``` Pixel 2: Before: 362.716 PR-27402: 185.799 PR-27341: 142.011 Pixel 3: Before: 246.755 PR-27402: 160.045 PR-27341: 115.437 ``` Single-threaded: ``` Pixel 2: Before: 308.084 PR-27340: 303.539 PR-27341: 313.558 Pixel 3: Before: 234.272 PR-27340: 227.158 PR-27341: 232.787 ``` [ghstack-poisoned]
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 9, 2019
…read pool implementation. (#27341) Summary: Pull Request resolved: pytorch/pytorch#27341 Multi-threaded: ``` Pixel 2: Before: 362.716 PR-27402: 185.799 PR-27341: 142.011 Pixel 3: Before: 246.755 PR-27402: 160.045 PR-27341: 115.437 ``` Single-threaded: ``` Pixel 2: Before: 308.084 PR-27340: 303.539 PR-27341: 313.558 Pixel 3: Before: 234.272 PR-27340: 227.158 PR-27341: 232.787 ``` Test Plan: Imported from OSS Differential Revision: D17835333 Pulled By: AshkanAliabadi fbshipit-source-id: 9502c230d8567b141ae93f611ac524d855ed9bdf
Contributor
|
@AshkanAliabadi merged this pull request in 283f481. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Multi-threaded:
Single-threaded:
Differential Revision: D17835333