Handle uninitialized min/max values in histogram observer#27151
Closed
raghuramank100 wants to merge 1 commit intogh/raghuraman_k/3/basefrom
Closed
Handle uninitialized min/max values in histogram observer#27151raghuramank100 wants to merge 1 commit intogh/raghuraman_k/3/basefrom
raghuramank100 wants to merge 1 commit intogh/raghuraman_k/3/basefrom
Conversation
We need to be ab le to handle observers with no min/max data correctly as models sometimes have modules that do not get any data. Differential Revision: [D17690828](https://our.internmc.facebook.com/intern/diff/D17690828/) [ghstack-poisoned]
raghuramank100
pushed a commit
that referenced
this pull request
Oct 1, 2019
We need to be ab le to handle observers with no min/max data correctly as models sometimes have modules that do not get any data. Differential Revision: [D17690828](https://our.internmc.facebook.com/intern/diff/D17690828/) ghstack-source-id: 91113403 Pull Request resolved: #27151
Contributor
|
This pull request has been merged in 4abfb54. |
This was referenced Oct 2, 2019
jamesr66a
pushed a commit
that referenced
this pull request
Oct 3, 2019
Summary: Pull Request resolved: #27151 We need to be ab le to handle observers with no min/max data correctly as models sometimes have modules that do not get any data. ghstack-source-id: 91113403 Test Plan: buck test caffe2/test:quantization -- test_minmax_observer buck test caffe2/test:quantization -- test_per_channel_minmax_observer buck test caffe2/test:quantization --test_histogram_observer Reviewed By: csummersea Differential Revision: D17690828 fbshipit-source-id: e95709333ea0f66d79ddb8141b7cba5a83347dbd
jamesr66a
pushed a commit
that referenced
this pull request
Oct 3, 2019
Summary: Pull Request resolved: #27151 We need to be ab le to handle observers with no min/max data correctly as models sometimes have modules that do not get any data. ghstack-source-id: 91113403 Test Plan: buck test caffe2/test:quantization -- test_minmax_observer buck test caffe2/test:quantization -- test_per_channel_minmax_observer buck test caffe2/test:quantization --test_histogram_observer Reviewed By: csummersea Differential Revision: D17690828 fbshipit-source-id: e95709333ea0f66d79ddb8141b7cba5a83347dbd
jamesr66a
pushed a commit
that referenced
this pull request
Oct 3, 2019
Summary: Pull Request resolved: #27151 We need to be ab le to handle observers with no min/max data correctly as models sometimes have modules that do not get any data. ghstack-source-id: 91113403 Test Plan: buck test caffe2/test:quantization -- test_minmax_observer buck test caffe2/test:quantization -- test_per_channel_minmax_observer buck test caffe2/test:quantization --test_histogram_observer Reviewed By: csummersea Differential Revision: D17690828 fbshipit-source-id: e95709333ea0f66d79ddb8141b7cba5a83347dbd
jamesr66a
pushed a commit
that referenced
this pull request
Oct 4, 2019
Summary: Pull Request resolved: #27151 We need to be ab le to handle observers with no min/max data correctly as models sometimes have modules that do not get any data. ghstack-source-id: 91113403 Test Plan: buck test caffe2/test:quantization -- test_minmax_observer buck test caffe2/test:quantization -- test_per_channel_minmax_observer buck test caffe2/test:quantization --test_histogram_observer Reviewed By: csummersea Differential Revision: D17690828 fbshipit-source-id: e95709333ea0f66d79ddb8141b7cba5a83347dbd
jamesr66a
pushed a commit
that referenced
this pull request
Oct 4, 2019
Summary: Pull Request resolved: #27151 We need to be ab le to handle observers with no min/max data correctly as models sometimes have modules that do not get any data. ghstack-source-id: 91113403 Test Plan: buck test caffe2/test:quantization -- test_minmax_observer buck test caffe2/test:quantization -- test_per_channel_minmax_observer buck test caffe2/test:quantization --test_histogram_observer Reviewed By: csummersea Differential Revision: D17690828 fbshipit-source-id: e95709333ea0f66d79ddb8141b7cba5a83347dbd
soumith
pushed a commit
that referenced
this pull request
Oct 7, 2019
Summary: Pull Request resolved: #27151 We need to be ab le to handle observers with no min/max data correctly as models sometimes have modules that do not get any data. ghstack-source-id: 91113403 Test Plan: buck test caffe2/test:quantization -- test_minmax_observer buck test caffe2/test:quantization -- test_per_channel_minmax_observer buck test caffe2/test:quantization --test_histogram_observer Reviewed By: csummersea Differential Revision: D17690828 fbshipit-source-id: e95709333ea0f66d79ddb8141b7cba5a83347dbd
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
) Summary: Pull Request resolved: pytorch#27151 We need to be ab le to handle observers with no min/max data correctly as models sometimes have modules that do not get any data. ghstack-source-id: 91113403 Test Plan: buck test caffe2/test:quantization -- test_minmax_observer buck test caffe2/test:quantization -- test_per_channel_minmax_observer buck test caffe2/test:quantization --test_histogram_observer Reviewed By: csummersea Differential Revision: D17690828 fbshipit-source-id: e95709333ea0f66d79ddb8141b7cba5a83347dbd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We need to be ab le to handle observers with no min/max data correctly as models sometimes have modules that do not get any data.
Differential Revision: D17690828