Don't apply should_run to the nightly/postnightly branches.#27061
Closed
ezyang wants to merge 1 commit intogh/ezyang/391/basefrom
Closed
Don't apply should_run to the nightly/postnightly branches.#27061ezyang wants to merge 1 commit intogh/ezyang/391/basefrom
ezyang wants to merge 1 commit intogh/ezyang/391/basefrom
Conversation
Previously the cronjobs were run on master, but now the nightly builds count as "PRs" so we must whitelist them from should_run calculation. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
fmassa
approved these changes
Sep 30, 2019
Contributor
soumith
pushed a commit
that referenced
this pull request
Oct 4, 2019
Summary: Pull Request resolved: #27061 Previously the cronjobs were run on master, but now the nightly builds count as "PRs" so we must whitelist them from should_run calculation. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Differential Revision: D17669066 Pulled By: ezyang fbshipit-source-id: 3b92bf1d09aefa7ef524ea93dfa8c6f566161887
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
…27061) Summary: Pull Request resolved: pytorch#27061 Previously the cronjobs were run on master, but now the nightly builds count as "PRs" so we must whitelist them from should_run calculation. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Differential Revision: D17669066 Pulled By: ezyang fbshipit-source-id: 3b92bf1d09aefa7ef524ea93dfa8c6f566161887
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Previously the cronjobs were run on master, but now the nightly builds
count as "PRs" so we must whitelist them from should_run calculation.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D17669066