[quant][pt1] Uninitialize the accumulation buffer to save some overhead#27005
Closed
jianyuh wants to merge 2 commits intogh/jianyuh/32/basefrom
Closed
[quant][pt1] Uninitialize the accumulation buffer to save some overhead#27005jianyuh wants to merge 2 commits intogh/jianyuh/32/basefrom
jianyuh wants to merge 2 commits intogh/jianyuh/32/basefrom
Conversation
Similar to #27002, we want to save some overhead. Differential Revision: [D17641819](https://our.internmc.facebook.com/intern/diff/D17641819/) [ghstack-poisoned]
jianyuh
added a commit
that referenced
this pull request
Sep 27, 2019
Similar to #27002, we want to save some overhead. Differential Revision: [D17641819](https://our.internmc.facebook.com/intern/diff/D17641819/) ghstack-source-id: 90963482 Pull Request resolved: #27005
jamesr66a
requested changes
Sep 28, 2019
Collaborator
jamesr66a
left a comment
There was a problem hiding this comment.
There's an error, please see CI
Member
Author
|
Right: It shows an error as the follows: I think |
Contributor
|
Does empty_zeros call something like memset? |
Contributor
|
the error is raised from: https://bddppq.github.io/codebrowser/pytorch/pytorch/aten/src/ATen/native/TensorFactories.cpp.html#217 |
…some overhead" Similar to #27002, we want to save some overhead. Differential Revision: [D17641819](https://our.internmc.facebook.com/intern/diff/D17641819/) [ghstack-poisoned]
jianyuh
added a commit
that referenced
this pull request
Sep 30, 2019
Pull Request resolved: #27005 Similar to #27002, we want to save some overhead. ghstack-source-id: 91046563 Differential Revision: [D17641819](https://our.internmc.facebook.com/intern/diff/D17641819/)
Member
Author
OK, it looks like I now switch to |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 1, 2019
Summary: Pull Request resolved: pytorch/pytorch#27005 Similar to pytorch/pytorch#27002, we want to save some overhead. ghstack-source-id: 91046563 Test Plan: CI Differential Revision: D17641819 fbshipit-source-id: 9320919242a48f48532035e61d9844de671d39af
Contributor
|
This pull request has been merged in 6a09676. |
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
…7005) Summary: Pull Request resolved: pytorch#27005 Similar to pytorch#27002, we want to save some overhead. ghstack-source-id: 91046563 Test Plan: CI Differential Revision: D17641819 fbshipit-source-id: 9320919242a48f48532035e61d9844de671d39af
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Similar to #27002, we want to save some overhead.
Differential Revision: D17641819