[pytorch][mobile][size] move parallel_for/parallel_reduce common implementation to cpp#26969
Closed
ljk53 wants to merge 3 commits intogh/ljk53/62/basefrom
Closed
[pytorch][mobile][size] move parallel_for/parallel_reduce common implementation to cpp#26969ljk53 wants to merge 3 commits intogh/ljk53/62/basefrom
ljk53 wants to merge 3 commits intogh/ljk53/62/basefrom
Conversation
…ementation to cpp Summary: template got inflated into many places. This PR extracted out common implementation that doesn't depend on template param. After: Compressed ARMv7 AAR size: 5,677,469->5,398,011 RAW libpytorch.so size: 16,862,108->16,047,004 Test Plan: - Test perf/correctness as #26702; - Run tests for non-mobile native aten_threading: ``` ATEN_THREADING=NATIVE python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch pytest -s -v test/test_jit.py ``` [ghstack-poisoned]
ljk53
added a commit
that referenced
this pull request
Sep 27, 2019
…ementation to cpp Summary: template got inflated into many places. This PR extracted out common implementation that doesn't depend on template param. After: Compressed ARMv7 AAR size: 5,677,469->5,398,011 RAW libpytorch.so size: 16,862,108->16,047,004 Test Plan: - Test perf/correctness as #26702; - Run tests for non-mobile native aten_threading: ``` ATEN_THREADING=NATIVE python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch pytest -s -v test/test_jit.py ``` ghstack-source-id: 01dd2d2 Pull Request resolved: #26969
ilia-cher
approved these changes
Sep 28, 2019
…common implementation to cpp" Summary: template got inflated into many places. This PR extracted out common implementation that doesn't depend on template param. After: Compressed ARMv7 AAR size: 5,677,469->5,398,011 RAW libpytorch.so size: 16,862,108->16,047,004 Test Plan: - Test perf/correctness as #26702; - Run tests for non-mobile native aten_threading: ``` ATEN_THREADING=NATIVE python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch pytest -s -v test/test_jit.py ``` Differential Revision: [D17628089](https://our.internmc.facebook.com/intern/diff/D17628089) [ghstack-poisoned]
…common implementation to cpp" Summary: template got inflated into many places. This PR extracted out common implementation that doesn't depend on template param. After: Compressed ARMv7 AAR size: 5,677,469->5,398,011 RAW libpytorch.so size: 16,862,108->16,047,004 Test Plan: - Test perf/correctness as #26702; - Run tests for non-mobile native aten_threading: ``` ATEN_THREADING=NATIVE python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch pytest -s -v test/test_jit.py ``` Differential Revision: [D17628089](https://our.internmc.facebook.com/intern/diff/D17628089) [ghstack-poisoned]
ljk53
added a commit
that referenced
this pull request
Sep 28, 2019
…ementation to cpp Summary: template got inflated into many places. This PR extracted out common implementation that doesn't depend on template param. After: Compressed ARMv7 AAR size: 5,677,469->5,398,011 RAW libpytorch.so size: 16,862,108->16,047,004 Test Plan: - Test perf/correctness as #26702; - Run tests for non-mobile native aten_threading: ``` ATEN_THREADING=NATIVE python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch pytest -s -v test/test_jit.py ``` ghstack-source-id: 64b91e0 Pull Request resolved: #26969
ljk53
added a commit
to ljk53/pytorch
that referenced
this pull request
Sep 28, 2019
…ch#26969) Summary: Pull Request resolved: pytorch#26969 template got inflated into many places. This PR extracted out common implementation that doesn't depend on template param. After: Compressed ARMv7 AAR size: 5,677,469->5,398,011 RAW libpytorch.so size: 16,862,108->16,047,004 Test Plan: - Test perf/correctness as pytorch#26702; - Run tests for non-mobile native aten_threading: ``` ATEN_THREADING=NATIVE python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch pytest -s -v test/test_jit.py ``` Differential Revision: D17628089 Pulled By: ljk53 fbshipit-source-id: 987d1f28174870384d6642d0bd4912b138348f66
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 28, 2019
Summary: Pull Request resolved: pytorch/pytorch#26969 template got inflated into many places. This PR extracted out common implementation that doesn't depend on template param. After: Compressed ARMv7 AAR size: 5,677,469->5,398,011 RAW libpytorch.so size: 16,862,108->16,047,004 Test Plan: - Test perf/correctness as #26702; - Run tests for non-mobile native aten_threading: ``` ATEN_THREADING=NATIVE python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch pytest -s -v test/test_jit.py ``` Differential Revision: D17628089 Pulled By: ljk53 fbshipit-source-id: 987d1f28174870384d6642d0bd4912b138348f66
soumith
pushed a commit
that referenced
this pull request
Oct 4, 2019
Summary: Pull Request resolved: #26969 template got inflated into many places. This PR extracted out common implementation that doesn't depend on template param. After: Compressed ARMv7 AAR size: 5,677,469->5,398,011 RAW libpytorch.so size: 16,862,108->16,047,004 Test Plan: - Test perf/correctness as #26702; - Run tests for non-mobile native aten_threading: ``` ATEN_THREADING=NATIVE python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch pytest -s -v test/test_jit.py ``` Differential Revision: D17628089 Pulled By: ljk53 fbshipit-source-id: 987d1f28174870384d6642d0bd4912b138348f66
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
…ch#26969) Summary: Pull Request resolved: pytorch#26969 template got inflated into many places. This PR extracted out common implementation that doesn't depend on template param. After: Compressed ARMv7 AAR size: 5,677,469->5,398,011 RAW libpytorch.so size: 16,862,108->16,047,004 Test Plan: - Test perf/correctness as pytorch#26702; - Run tests for non-mobile native aten_threading: ``` ATEN_THREADING=NATIVE python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch pytest -s -v test/test_jit.py ``` Differential Revision: D17628089 Pulled By: ljk53 fbshipit-source-id: 987d1f28174870384d6642d0bd4912b138348f66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
template got inflated into many places. This PR extracted out common
implementation that doesn't depend on template param.
After:
Compressed ARMv7 AAR size: 5,677,469->5,398,011
RAW libpytorch.so size: 16,862,108->16,047,004
Test Plan:
Test perf/correctness as [pytorch][perf] add mobile friendly at:parallel_for backend #26702;
Run tests for non-mobile native aten_threading:
Differential Revision: D17628089