[Caffe2] Fix the weird bug in control_flow_op_test.py#26931
Closed
houseroad wants to merge 1 commit intopytorch:masterfrom
Closed
[Caffe2] Fix the weird bug in control_flow_op_test.py#26931houseroad wants to merge 1 commit intopytorch:masterfrom
houseroad wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
f25e4b0 to
44b9fb1
Compare
Member
Author
|
The culprit is how we handle extra kwargs in core.CreateOperator. Different version of python has different orders when iterating over the kwargs. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@houseroad merged this pull request in 7163bfd. |
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: In some version of python, then_net and else_net may switch the order. Let's make sure we are iterating the right arg node. Pull Request resolved: pytorch#26931 Reviewed By: hl475 Differential Revision: D17614829 Pulled By: houseroad fbshipit-source-id: 3f1b4eb91ecf4d808f58c34896d3e628aa2e0af0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some version of python, then_net and else_net may switch the order. Let's make sure we are iterating the right arg node.