Include iteration_ in SGD optimizer serialization#26906
Closed
yf225 wants to merge 1 commit intopytorch:masterfrom
Closed
Include iteration_ in SGD optimizer serialization#26906yf225 wants to merge 1 commit intopytorch:masterfrom
iteration_ in SGD optimizer serialization#26906yf225 wants to merge 1 commit intopytorch:masterfrom
Conversation
yf225
commented
Sep 26, 2019
|
|
||
| /// Counts how often `step()` is called, for dampening. | ||
| size_t iteration_{0}; | ||
| int64_t iteration_{0}; |
Contributor
Author
There was a problem hiding this comment.
This is changed from size_t to int64_t, because IValue doesn't support storing a size_t value.
pbelevich
approved these changes
Sep 27, 2019
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: This PR fixes pytorch#24192 by including the private field `iteration_` in SGD optimizer serialization. Under the hood, `iteration_` is serialized into an `IValue`, then stored in a JIT module as an attribute. Pull Request resolved: pytorch#26906 Differential Revision: D17628359 Pulled By: yf225 fbshipit-source-id: beec1367459e973a1c9080dc86f502e4c7bc5ebd
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: This PR fixes pytorch#24192 by including the private field `iteration_` in SGD optimizer serialization. Under the hood, `iteration_` is serialized into an `IValue`, then stored in a JIT module as an attribute. Pull Request resolved: pytorch#26906 Differential Revision: D17628359 Pulled By: yf225 fbshipit-source-id: beec1367459e973a1c9080dc86f502e4c7bc5ebd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #24192 by including the private field
iteration_in SGD optimizer serialization. Under the hood,iteration_is serialized into anIValue, then stored in a JIT module as an attribute.