[ONNX] export baddbmm#26901
Closed
neginraoof wants to merge 20 commits intopytorch:masterfrom
Closed
Conversation
test baddbmm args as model inputs
removed type-casts following pytorch#24378 PR
Contributor
Author
|
@BowenBao for review |
Contributor
Author
|
cc @houseroad I recreated this for baddbmm |
BowenBao
reviewed
Sep 26, 2019
Collaborator
BowenBao
left a comment
There was a problem hiding this comment.
LGTM, tests should pass now after removing the unnecessary parse_arg which restricts alpha/beta to be constants instead of values.
I wonder if we could export baddbmm with onnx::Gemm?
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
We're not using onnx::Gemm since onnx documentation for Gemm mentions that alpha and beta are attributes for this op. However, using our subgraph instead, we can pass alpha and beta as dynamic inputs. |
Contributor
|
@houseroad merged this pull request in 6b9bcd0. |
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: Adding symbolic for baddbmm export Pull Request resolved: pytorch#26901 Reviewed By: hl475 Differential Revision: D17620967 Pulled By: houseroad fbshipit-source-id: 3931dff5a4afdcb4a45d967fb0efaf84029c16e5
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Adding symbolic for baddbmm export Pull Request resolved: pytorch#26901 Reviewed By: hl475 Differential Revision: D17620967 Pulled By: houseroad fbshipit-source-id: 3931dff5a4afdcb4a45d967fb0efaf84029c16e5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding symbolic for baddbmm export