[pytorch][mobile] remove backward functions from jit-op-registry for mobile build#26783
Merged
ljk53 merged 3 commits intogh/ljk53/58/basefrom Sep 25, 2019
Merged
[pytorch][mobile] remove backward functions from jit-op-registry for mobile build#26783ljk53 merged 3 commits intogh/ljk53/58/basefrom
ljk53 merged 3 commits intogh/ljk53/58/basefrom
Conversation
…mobile build Summary: Add codegen option to remove backward ops from jit-op-registry as they are not likely to be used for inference only mobile build. Measured ARM-v7 AAR build size change: 5,804,182 -> 5,331,219. Test Plan: - build and integrate with demo app; [ghstack-poisoned]
This was referenced Sep 25, 2019
Contributor
Author
|
Recreate #26657 - that PR was marked as merged for some reason. |
…gistry for mobile build" Summary: Add codegen option to remove backward ops from jit-op-registry as they are not likely to be used for inference only mobile build. Measured ARM-v7 AAR build size change: 5,804,182 -> 5,331,219. Test Plan: - build and integrate with demo app; [ghstack-poisoned]
…gistry for mobile build" Summary: Add codegen option to remove backward ops from jit-op-registry as they are not likely to be used for inference only mobile build. Measured ARM-v7 AAR build size change: 5,804,182 -> 5,331,219. Test Plan: - build and integrate with demo app; [ghstack-poisoned]
ljk53
commented
Sep 25, 2019
| return decl['name'].endswith('_out') | ||
|
|
||
|
|
||
| # Copied from ..autograd.gen_python_functions.SKIP_PYTHON_BINDINGS |
Contributor
Author
There was a problem hiding this comment.
@zdevito is there a reason to bind other skipped python bindings for JIT? Can we safely skip all of them by default?
Collaborator
There was a problem hiding this comment.
There's symbolic differentiation support in JIT. It'd append IR for backwards directly to the graph. For those cases we need to have backwards ops registered and runnable. (at least that's my understanding)
dzhulgakov
reviewed
Sep 25, 2019
| return decl['name'].endswith('_out') | ||
|
|
||
|
|
||
| # Copied from ..autograd.gen_python_functions.SKIP_PYTHON_BINDINGS |
Collaborator
There was a problem hiding this comment.
There's symbolic differentiation support in JIT. It'd append IR for backwards directly to the graph. For those cases we need to have backwards ops registered and runnable. (at least that's my understanding)
ljk53
added a commit
that referenced
this pull request
Sep 25, 2019
…mobile build Summary: Add codegen option to remove backward ops from jit-op-registry as they are not likely to be used for inference only mobile build. Measured ARM-v7 AAR build size change: 5,804,182 -> 5,331,219. Test Plan: - build and integrate with demo app; ghstack-source-id: 6716a80 Pull Request resolved: #26783
Contributor
Author
|
ahh... this PR got marked as merged again.. I'll recreate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Add codegen option to remove backward ops from jit-op-registry as they are not
likely to be used for inference only mobile build.
Measured ARM-v7 AAR build size change: 5,804,182 -> 5,331,219.
Test Plan:
Differential Revision: D17570054