Move the CUDA implementation of log2 to ATen.#26769
Closed
xuhdev wants to merge 15 commits intogh/xuhdev/37/basefrom
Closed
Move the CUDA implementation of log2 to ATen.#26769xuhdev wants to merge 15 commits intogh/xuhdev/37/basefrom
xuhdev wants to merge 15 commits intogh/xuhdev/37/basefrom
Conversation
This was referenced Sep 24, 2019
VitalyFedyunin
approved these changes
Oct 3, 2019
Contributor
VitalyFedyunin
left a comment
There was a problem hiding this comment.
LGTM, please rebase after landing of #26733
Collaborator
Author
|
Absolutely! |
Fix #24589 [ghstack-poisoned]
Collaborator
Author
|
@VitalyFedyunin Rebased |
Fix #24589 [ghstack-poisoned]
Collaborator
Author
|
Rebased to resolve a conflict |
Fix #24589 [ghstack-poisoned]
Collaborator
Author
|
@VitalyFedyunin Are you landing this one? I can do a rebase if you are not |
Contributor
|
Feel free to rebase, I will land right after (please ping me) |
Fix #24589 [ghstack-poisoned]
Collaborator
Author
|
@VitalyFedyunin Done! |
Contributor
|
@VitalyFedyunin merged this pull request in 4a69d04. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 17, 2019
Summary: Pull Request resolved: pytorch/pytorch#26769 Fix #24589 Test Plan: Imported from OSS Differential Revision: D17960122 Pulled By: VitalyFedyunin fbshipit-source-id: 58dff236886bbf3a0a152d7422aa8a5c478ee1de
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#26769 Fix pytorch#24589 Test Plan: Imported from OSS Differential Revision: D17960122 Pulled By: VitalyFedyunin fbshipit-source-id: 58dff236886bbf3a0a152d7422aa8a5c478ee1de
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fix #24589
Differential Revision: D17960122