[jit] serialize autograd ops into its own namespace#26761
Closed
wanchaol wants to merge 3 commits intogh/wanchaol/53/basefrom
Closed
[jit] serialize autograd ops into its own namespace#26761wanchaol wants to merge 3 commits intogh/wanchaol/53/basefrom
wanchaol wants to merge 3 commits intogh/wanchaol/53/basefrom
Conversation
Summary: This PR serialize autograd ops into its own namespace by turning the serialization op name into `torch.autograd.op`, this is to keep the original code namespace rather than turning all to the global namespace, this will be more properly handled in the future when we handle the module namespace. This change also preserve BC until we have namespace handling Test Plan: Reviewers: Subscribers: Tasks: Tags:
wanchaol
added a commit
that referenced
this pull request
Sep 24, 2019
Summary: This PR serialize autograd ops into its own namespace by turning the serialization op name into `torch.autograd.op`, this is to keep the original code namespace rather than turning all to the global namespace, this will be more properly handled in the future when we handle the module namespace. This change also preserve BC until we have namespace handling Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 5ee881f Pull Request resolved: #26761
zdevito
reviewed
Sep 25, 2019
| } | ||
|
|
||
| void printOpName(TaggedStringStream& stmt, Symbol kind) { | ||
| const static std::unordered_set<Symbol> autograd_ns_symbols = { |
Contributor
There was a problem hiding this comment.
This feels overly specific to autograd, it can just be a map from symbol to an override for how it is serialized:
{aten::backward, "torch.autograd.backward"},
…ace" Summary: This PR serialize autograd ops into its own namespace by turning the serialization op name into `torch.autograd.op`, this is to keep the original code namespace rather than turning all to the global namespace, this will be more properly handled in the future when we handle the module namespace. This change also preserve BC until we have namespace handling Test Plan: Reviewers: Subscribers: Tasks: Tags:
wanchaol
added a commit
that referenced
this pull request
Sep 25, 2019
Summary: This PR serialize autograd ops into its own namespace by turning the serialization op name into `torch.autograd.op`, this is to keep the original code namespace rather than turning all to the global namespace, this will be more properly handled in the future when we handle the module namespace. This change also preserve BC until we have namespace handling Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 5b25074 Pull Request resolved: #26761
Summary: This PR serialize autograd ops into its own namespace by turning the serialization op name into `torch.autograd.op`, this is to keep the original code namespace rather than turning all to the global namespace, this will be more properly handled in the future when we handle the module namespace. This change also preserve BC until we have namespace handling Test Plan: Reviewers: Subscribers: Tasks: Tags:
wanchaol
added a commit
that referenced
this pull request
Sep 27, 2019
Summary: This PR serialize autograd ops into its own namespace by turning the serialization op name into `torch.autograd.op`, this is to keep the original code namespace rather than turning all to the global namespace, this will be more properly handled in the future when we handle the module namespace. This change also preserve BC until we have namespace handling Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 07322ed Pull Request resolved: #26761
zdevito
approved these changes
Sep 27, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 30, 2019
Summary: Pull Request resolved: pytorch/pytorch#26761 This PR serialize autograd ops into its own namespace by turning the serialization op name into `torch.autograd.op`, this is to keep the original code namespace rather than turning all to the global namespace, this will be more properly handled in the future when we handle the module namespace. This change also preserve BC until we have namespace handling Test Plan: Imported from OSS Differential Revision: D17645438 fbshipit-source-id: 656ec6b31d4fc2252585de73117c4d40a122678e
Contributor
|
This pull request has been merged in a252aee. |
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: Pull Request resolved: pytorch#26761 This PR serialize autograd ops into its own namespace by turning the serialization op name into `torch.autograd.op`, this is to keep the original code namespace rather than turning all to the global namespace, this will be more properly handled in the future when we handle the module namespace. This change also preserve BC until we have namespace handling Test Plan: Imported from OSS Differential Revision: D17645438 fbshipit-source-id: 656ec6b31d4fc2252585de73117c4d40a122678e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This PR serialize autograd ops into its own namespace by turning the
serialization op name into
torch.autograd.op, this is to keep theoriginal code namespace rather than turning all to the global namespace,
this will be more properly handled in the future when we handle the module
namespace. This change also preserve BC until we have namespace handling
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D17645438