[pytorch] rename caffe2::mobile_threadpool to caffe2::mobile_pthreadpool#26700
Closed
ljk53 wants to merge 5 commits intogh/ljk53/55/basefrom
Closed
[pytorch] rename caffe2::mobile_threadpool to caffe2::mobile_pthreadpool#26700ljk53 wants to merge 5 commits intogh/ljk53/55/basefrom
ljk53 wants to merge 5 commits intogh/ljk53/55/basefrom
Conversation
Summary: Rename old mobile_threadpool() API, replace it with a new version that returns caffe2::ThreadPool instead of pthreadpool_t. Test Plan: - builds [ghstack-poisoned]
This was referenced Sep 24, 2019
…le_pthreadpool" Summary: Rename old mobile_threadpool() API, replace it with a new version that returns caffe2::ThreadPool instead of pthreadpool_t. Test Plan: - builds Differential Revision: [D17543413](https://our.internmc.facebook.com/intern/diff/D17543413) [ghstack-poisoned]
dreiss
approved these changes
Sep 24, 2019
Contributor
|
I just landed #26728. So please rebase before submitting. |
…le_pthreadpool" Summary: Rename old mobile_threadpool() API, replace it with a new version that returns caffe2::ThreadPool instead of pthreadpool_t. Test Plan: - builds Differential Revision: [D17543413](https://our.internmc.facebook.com/intern/diff/D17543413) [ghstack-poisoned]
Contributor
|
@ljk53 why the onnx submodule update? |
…le_pthreadpool" Summary: Rename old mobile_threadpool() API, replace it with a new version that returns caffe2::ThreadPool instead of pthreadpool_t. Test Plan: - builds Differential Revision: [D17543413](https://our.internmc.facebook.com/intern/diff/D17543413) [ghstack-poisoned]
…le_pthreadpool" Summary: Rename old mobile_threadpool() API, replace it with a new version that returns caffe2::ThreadPool instead of pthreadpool_t. Test Plan: - builds Differential Revision: [D17543413](https://our.internmc.facebook.com/intern/diff/D17543413) [ghstack-poisoned]
supriyar
approved these changes
Sep 25, 2019
Contributor
Author
|
Closing as it's already landed. |
karansachdev-1012
pushed a commit
to karansachdev-1012/pytorch
that referenced
this pull request
Feb 17, 2026
Summary: Rename old mobile_threadpool() API, replace it with a new version that returns caffe2::ThreadPool instead of pthreadpool_t. Test Plan: - builds ghstack-source-id: 56a093a Pull Request resolved: pytorch/pytorch#26700
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Rename old mobile_threadpool() API, replace it with a new version that
returns caffe2::ThreadPool instead of pthreadpool_t.
Test Plan:
Differential Revision: D17543413