[rename] _per_tensor_affine_qtensor -> _make_per_tensor_quantized_tensor#26678
Closed
jerryzh168 wants to merge 1 commit intogh/jerryzh168/88/basefrom
Closed
[rename] _per_tensor_affine_qtensor -> _make_per_tensor_quantized_tensor#26678jerryzh168 wants to merge 1 commit intogh/jerryzh168/88/basefrom
jerryzh168 wants to merge 1 commit intogh/jerryzh168/88/basefrom
Conversation
Summary: att Test Plan: ci Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Sep 23, 2019
jianyuh
approved these changes
Sep 23, 2019
Member
jianyuh
left a comment
There was a problem hiding this comment.
LGTM! In the summary, please add the reason for adding _make: making it more explicit that it's a factory function.
Contributor
|
This pull request has been merged in d63143d. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 24, 2019
Summary: Pull Request resolved: pytorch/pytorch#26678 making it more explicit that it's a factory function. Test Plan: ci Imported from OSS Differential Revision: D17540862 fbshipit-source-id: 14c5a4dcc7bb85ae849c9e4e0882601005e2ed3a
Member
|
This breaks |
Contributor
Author
|
what does that do? this is backward incompatible change in terms of API |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
making it more explicit that it's a factory function.
Test Plan:
ci
Reviewers:
pt1quant
Subscribers:
Tasks:
Tags:
Differential Revision: D17540862