Skip to content

[refactor] Add ObserveHelper and remove some common function parameters#26641

Closed
jerryzh168 wants to merge 2 commits intogh/jerryzh168/86/basefrom
gh/jerryzh168/86/head
Closed

[refactor] Add ObserveHelper and remove some common function parameters#26641
jerryzh168 wants to merge 2 commits intogh/jerryzh168/86/basefrom
gh/jerryzh168/86/head

Conversation

@jerryzh168
Copy link
Copy Markdown
Contributor

@jerryzh168 jerryzh168 commented Sep 23, 2019

Stack from ghstack:

Summary:
att

Test Plan:
python test/test_jit.py 'TestJit.test_insert_observers*'
Reviewers:
mvz

Subscribers:

Tasks:

Tags:

Differential Revision: D17538668

Summary:
att

Test Plan:
python test/test_jit.py 'TestJit.test_insert_observers*'
Reviewers:
mvz

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Copy link
Copy Markdown

@ZolotukhinM ZolotukhinM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Comment thread torch/csrc/jit/passes/quantization.cpp
Comment thread torch/csrc/jit/passes/quantization.cpp Outdated
Comment thread torch/csrc/jit/passes/quantization.cpp
…on parameters"

Summary:
att

Test Plan:
python test/test_jit.py 'TestJit.test_insert_observers*'
Reviewers:
mvz

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 7d61206.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/86/head branch October 28, 2019 22:15
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
…#26641)

Summary:
Pull Request resolved: pytorch#26641

att

Test Plan:
python test/test_jit.py 'TestJit.test_insert_observers*'

Imported from OSS

Differential Revision: D17538668

fbshipit-source-id: 42d0b251b245337227f877e57611b50f392a6d7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants