[quant] Expose supportedQEngines to python#26474
Closed
jerryzh168 wants to merge 6 commits intogh/jerryzh168/78/basefrom
Closed
[quant] Expose supportedQEngines to python#26474jerryzh168 wants to merge 6 commits intogh/jerryzh168/78/basefrom
jerryzh168 wants to merge 6 commits intogh/jerryzh168/78/basefrom
Conversation
Summary: att Test Plan: python test/test_torch.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Sep 19, 2019
Summary: att Test Plan: python test/test_torch.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
supriyar
reviewed
Sep 19, 2019
| qengines = torch._C._supported_qengines() | ||
| # [TODO] Enable after the interface change | ||
| # original_qe = torch._C._get_qengine() | ||
| # for qe in qengines: |
Contributor
There was a problem hiding this comment.
qe is an int but set_qengine expects at::QEngine. Will this work?
Contributor
Author
There was a problem hiding this comment.
it doens't work right now that's why I commented them out. it should work after the interface change. we should be returning/pass int in _get_qengine and _set_qengine as well
Summary: att Test Plan: python test/test_torch.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: python test/test_torch.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
supriyar
approved these changes
Sep 20, 2019
Contributor
supriyar
left a comment
There was a problem hiding this comment.
Looks good.
The plan after this is to change qengine to string (user facing) and return an int from supported_qengines.
Contributor
Author
|
plan is to change |
Summary: att Test Plan: python test/test_torch.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: att Test Plan: python test/test_torch.py Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
|
This pull request has been merged in 2667493. |
mingbowan
pushed a commit
to mingbowan/pytorch
that referenced
this pull request
Sep 23, 2019
Summary: Pull Request resolved: pytorch#26474 att Test Plan: python test/test_torch.py Imported from OSS Differential Revision: D17517373 fbshipit-source-id: af931761d6ee31a88808d05f686002a83b6b25af
xxtEchjovs44
pushed a commit
to xxtEchjovs44/pytorch
that referenced
this pull request
Jan 29, 2020
Summary: att Test Plan: python test/test_torch.py Reviewers: pt1quant Subscribers: Tasks: Tags: ghstack-source-id: 6688d99 Pull Request resolved: pytorch/pytorch#26474
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
att
Test Plan:
python test/test_torch.py
Reviewers:
pt1quant
Subscribers:
Tasks:
Tags:
Differential Revision: D17517373