Closed
Conversation
Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/) [ghstack-poisoned]
This was referenced Sep 18, 2019
Closed
smessmer
added a commit
that referenced
this pull request
Sep 18, 2019
Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/) ghstack-source-id: 90378058 Pull Request resolved: #26434
Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 19, 2019
Pull Request resolved: #26434 ghstack-source-id: 90395273 Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/)
25 tasks
Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/) [ghstack-poisoned]
Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 19, 2019
Pull Request resolved: #26434 ghstack-source-id: 90435818 Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/)
Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/) [ghstack-poisoned]
Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/) [ghstack-poisoned]
Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 19, 2019
Pull Request resolved: #26434 ghstack-source-id: 90459909 Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/)
ezyang
reviewed
Sep 20, 2019
aten/src/ATen/core/jit_type.h
Outdated
| static TypePtr call() { | ||
| if (!isCustomClassRegistered<T>()) { | ||
| throw c10::Error("Type could not be converted to any of the known types.", ""); | ||
| throw c10::Error(std::string() + "Type " + typeid(T).name() + " could not be converted to any of the known types.", ""); |
Contributor
Author
There was a problem hiding this comment.
good catch. Seems I forgot to remove my debug code...
I'm actually hoping to enable this after the gcc5 switch using compile time type identification, having a better error message here would be really nice, but that's separate from this PR.
Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 21, 2019
Pull Request resolved: #26434 ghstack-source-id: 90548550 Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/)
Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 21, 2019
Pull Request resolved: #26434 ghstack-source-id: 90552742 Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/)
Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 22, 2019
Pull Request resolved: #26434 ghstack-source-id: 90557243 Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/)
Contributor
Author
|
@ezyang can you take another look? |
ezyang
approved these changes
Sep 26, 2019
Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Sep 27, 2019
Pull Request resolved: #26434 ghstack-source-id: 90902124 Differential Revision: [D17465434](https://our.internmc.facebook.com/intern/diff/D17465434/)
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 27, 2019
Summary: Pull Request resolved: pytorch/pytorch#26434 ghstack-source-id: 90902124 Test Plan: unit tests Differential Revision: D17465434 fbshipit-source-id: 469206d44e328c19008daf2f6a323dcd1ac97984
Contributor
|
This pull request has been merged in b60656b. |
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: Pull Request resolved: pytorch#26434 ghstack-source-id: 90902124 Test Plan: unit tests Differential Revision: D17465434 fbshipit-source-id: 469206d44e328c19008daf2f6a323dcd1ac97984
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D17465434