[quant][graph] Add inplace argument to InsertObservers and InsertQuantDeQuant#26389
Closed
jerryzh168 wants to merge 13 commits intogh/jerryzh168/72/basefrom
Closed
[quant][graph] Add inplace argument to InsertObservers and InsertQuantDeQuant#26389jerryzh168 wants to merge 13 commits intogh/jerryzh168/72/basefrom
jerryzh168 wants to merge 13 commits intogh/jerryzh168/72/basefrom
Conversation
…tDeQuant Summary: att Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Sep 18, 2019
… InsertQuantDeQuant" Summary: att Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Sep 18, 2019
ZolotukhinM
approved these changes
Sep 18, 2019
ZolotukhinM
left a comment
There was a problem hiding this comment.
Overall looks good modulo couple of remarks (see inline)!
… InsertQuantDeQuant" Summary: att Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… InsertQuantDeQuant" Summary: att Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… InsertQuantDeQuant" Summary: att Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… InsertQuantDeQuant" Summary: att Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… InsertQuantDeQuant" Summary: att Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… InsertQuantDeQuant" Summary: att Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… InsertQuantDeQuant" Summary: att Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… InsertQuantDeQuant" Summary: att Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
… InsertQuantDeQuant" Summary: att Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17504458](https://our.internmc.facebook.com/intern/diff/D17504458) [ghstack-poisoned]
… InsertQuantDeQuant" Summary: att Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17504458](https://our.internmc.facebook.com/intern/diff/D17504458) [ghstack-poisoned]
… InsertQuantDeQuant" Summary: att Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17504458](https://our.internmc.facebook.com/intern/diff/D17504458) [ghstack-poisoned]
Contributor
|
This pull request has been merged in d09d1d9. |
mingbowan
pushed a commit
to mingbowan/pytorch
that referenced
this pull request
Sep 23, 2019
…ch#26389) Summary: Pull Request resolved: pytorch#26389 att Test Plan: . Imported from OSS Differential Revision: D17504458 fbshipit-source-id: a1a5c908eabf270c1e8d2098532ffc46978a240c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
att
Test Plan:
.
Reviewers:
pt1quant
Subscribers:
Tasks:
Tags:
Differential Revision: D17504458