Closed
Conversation
This PR doesn't delete the code for them yet because it takes some effort to determine what to delete. I will send a followup PR fully deleting tagged names, but this PR disables their creation. Test Plan: - [namedtensor ci]
This was referenced Sep 17, 2019
Closed
This PR doesn't delete the code for them yet because it takes some effort to determine what to delete. I will send a followup PR fully deleting tagged names, but this PR disables their creation. Test Plan: - [namedtensor ci] Pull Request resolved: #26356 Differential Revision: [D17428409](https://our.internmc.facebook.com/intern/diff/D17428409)
nairbv
reviewed
Sep 18, 2019
| check_valid_identifier(tag); | ||
| return Dimname(NameType::TAGGED, full_name, Symbol::dimname(untagged_name)); | ||
| check_valid_identifier(full_name.toUnqualString()); | ||
| return Dimname(full_name); |
Collaborator
There was a problem hiding this comment.
if we're getting rid of tagged names, should it just be "name" instead of "full_name"?
Contributor
Author
There was a problem hiding this comment.
I changed that in the next diff in the stack: #26365.
This one is to just disable creation of tagged names.
Contributor
Author
There was a problem hiding this comment.
I can merge the two PRs together (perhaps they make more sense as one unit) if that makes them easier to review.
nairbv
reviewed
Sep 18, 2019
| ASSERT_EQ(dimname.full_name(), foo); | ||
| ASSERT_EQ(dimname.untagged_name(), foo); | ||
|
|
||
| ASSERT_THROW(Dimname::fromSymbol(Symbol::dimname("inva.lid")), c10::Error); |
Collaborator
There was a problem hiding this comment.
what are we throwing in this case? that . isn't allowed?
Contributor
Author
There was a problem hiding this comment.
We are throwing the error message that says "only alphabetical and underscore characters are allowed"
nairbv
approved these changes
Sep 18, 2019
This PR doesn't delete the code for them yet because it takes some effort to determine what to delete. I will send a followup PR fully deleting tagged names, but this PR disables their creation. Test Plan: - [namedtensor ci] Pull Request resolved: #26356 Differential Revision: [D17428409](https://our.internmc.facebook.com/intern/diff/D17428409)
This PR doesn't delete the code for them yet because it takes some effort to determine what to delete. I will send a followup PR fully deleting tagged names, but this PR disables their creation. Test Plan: - [namedtensor ci] Pull Request resolved: #26356 Differential Revision: [D17428409](https://our.internmc.facebook.com/intern/diff/D17428409)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR doesn't delete the code for them yet because it takes some effort to
determine what to delete. I will send a followup PR fully deleting
tagged names, but this PR disables their creation.
Test Plan:
Pull Request resolved: #26356
Differential Revision: D17428409