Change "named_guard" in native_functions to "supports_named_tensor"#26352
Closed
zou3519 wants to merge 2 commits intogh/zou3519/174/basefrom
Closed
Change "named_guard" in native_functions to "supports_named_tensor"#26352zou3519 wants to merge 2 commits intogh/zou3519/174/basefrom
zou3519 wants to merge 2 commits intogh/zou3519/174/basefrom
Conversation
"named_guard: P" is the same as "supports_named_tensor: !P". Also changed the error message to be more understandable to users. Test Plan: - `TEST_NAMEDTENSOR=1 pytest test/test_namedtensor.py -v` - [namedtensor ci]
nairbv
approved these changes
Sep 18, 2019
Collaborator
nairbv
left a comment
There was a problem hiding this comment.
I agree this is much clearer
…d_tensor"" "named_guard: P" is the same as "supports_named_tensor: !P". Also changed the error message to be more understandable to users. Test Plan: - `TEST_NAMEDTENSOR=1 pytest test/test_namedtensor.py -v` - [namedtensor ci] Differential Revision: [D17426234](https://our.internmc.facebook.com/intern/diff/D17426234)
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 18, 2019
…#26352) Summary: Pull Request resolved: pytorch/pytorch#26352 "named_guard: P" is the same as "supports_named_tensor: !P". Also changed the error message to be more understandable to users. Test Plan: - `TEST_NAMEDTENSOR=1 pytest test/test_namedtensor.py -v` - [namedtensor ci] Differential Revision: D17426234 Pulled By: zou3519 fbshipit-source-id: 4cab780e6e29e184e79cdd3690f41df9ebb2ecb5
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ytorch#26352) Summary: Pull Request resolved: pytorch#26352 "named_guard: P" is the same as "supports_named_tensor: !P". Also changed the error message to be more understandable to users. Test Plan: - `TEST_NAMEDTENSOR=1 pytest test/test_namedtensor.py -v` - [namedtensor ci] Differential Revision: D17426234 Pulled By: zou3519 fbshipit-source-id: 4cab780e6e29e184e79cdd3690f41df9ebb2ecb5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
"named_guard: P" is the same as "supports_named_tensor: !P".
Also changed the error message to be more understandable to users.
Test Plan:
TEST_NAMEDTENSOR=1 pytest test/test_namedtensor.py -vDifferential Revision: D17426234