Rename torch.namedtensor -> torch._namedtensor_internals#26349
Closed
zou3519 wants to merge 2 commits intogh/zou3519/172/basefrom
Closed
Rename torch.namedtensor -> torch._namedtensor_internals#26349zou3519 wants to merge 2 commits intogh/zou3519/172/basefrom
zou3519 wants to merge 2 commits intogh/zou3519/172/basefrom
Conversation
The directory holds a lot of private helper functions that help implement named tensor functionality. Instead of naming each helper function with a leading underscore, I change the name of the import to `_namedtensor_internals` to signal it should not be used directly. Test Plan: - [namedtensor ci]
nairbv
approved these changes
Sep 17, 2019
The directory holds a lot of private helper functions that help implement named tensor functionality. Instead of naming each helper function with a leading underscore, I change the name of the import to `_namedtensor_internals` to signal it should not be used directly. Test Plan: - [namedtensor ci] Differential Revision: [D17424178](https://our.internmc.facebook.com/intern/diff/D17424178)
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#26349 The directory holds a lot of private helper functions that help implement named tensor functionality. Instead of naming each helper function with a leading underscore, I change the name of the import to `_namedtensor_internals` to signal it should not be used directly. Test Plan: - [namedtensor ci] Differential Revision: D17424178 Pulled By: zou3519 fbshipit-source-id: 8f7b74346765759303480e581038a661021acf53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
...for named tensor API functions. #26350 Change '*' to '...' and...for named tensor API functions.The directory holds a lot of private helper functions that help
implement named tensor functionality. Instead of naming each helper
function with a leading underscore, I change the name of the import to
_namedtensor_internalsto signal it should not be used directly.Test Plan:
Differential Revision: D17424178