Add a CI Job to Check BC Changes in Function Schemas#26329
Closed
houseroad wants to merge 4 commits intopytorch:masterfrom
Closed
Add a CI Job to Check BC Changes in Function Schemas#26329houseroad wants to merge 4 commits intopytorch:masterfrom
houseroad wants to merge 4 commits intopytorch:masterfrom
Conversation
85b77b8 to
d059a02
Compare
272bb4b to
47f617a
Compare
ezyang
reviewed
Sep 19, 2019
ezyang
reviewed
Sep 19, 2019
Contributor
There was a problem hiding this comment.
nit: need a space here, it shows up as 'changesfor'
ezyang
reviewed
Sep 19, 2019
586b2f3 to
78bb5ab
Compare
78bb5ab to
1cc0f40
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@houseroad merged this pull request in 30e7665. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Ready for review, and results, please check https://circleci.com/gh/pytorch/pytorch/2827354?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link Also, an experimental PR stacked on this have caught bc-breaking changes introduced by it. pytorch#26398 Pull Request resolved: pytorch#26329 Reviewed By: hl475 Differential Revision: D17485668 Pulled By: houseroad fbshipit-source-id: b10682f1785a20ea04521992e0973b1380b4dd3b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review, and results, please check https://circleci.com/gh/pytorch/pytorch/2827354?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
Also, an experimental PR stacked on this have caught bc-breaking changes introduced by it.
#26398