Make ProcessGroupAgent take num_threads as constructor argument#26313
Closed
xush6528 wants to merge 1 commit intopytorch:masterfrom
Closed
Make ProcessGroupAgent take num_threads as constructor argument#26313xush6528 wants to merge 1 commit intopytorch:masterfrom
xush6528 wants to merge 1 commit intopytorch:masterfrom
Conversation
mrshenli
reviewed
Sep 16, 2019
Contributor
mrshenli
left a comment
There was a problem hiding this comment.
Do you also need to add that to init_model_parallel as that's the entry point API?
zhaojuanmao
reviewed
Sep 16, 2019
Contributor
There was a problem hiding this comment.
where is rpc_backend from? should it not be "backend"?
Contributor
Author
There was a problem hiding this comment.
@zhaojuanmao Thanks. That's in @satgera 's next PR. I am keeping each PR atomic.
Contributor
Author
|
@mrshenli Right, updating it. |
ff6dcdc to
31dacb4
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@xush6528 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
31dacb4 to
c10526f
Compare
c10526f to
f46b44c
Compare
mrshenli
approved these changes
Sep 18, 2019
…ment (pytorch#26313) Summary: # Problem If there is not enough number of thread in the RPC Agent thread pool. Some circular dependent works could cause deadlock. The current to way to get around this deadlock is to provide abundant number of threads. # Solution as titled Pull Request resolved: pytorch#26313 Differential Revision: D17405491 Pulled By: xush6528 fbshipit-source-id: e9b34db50b0ab614ebcb3414ae615ad1cde259ce
f46b44c to
730d46c
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@xush6528 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ment (pytorch#26313) Summary: # Problem If there is not enough number of thread in the RPC Agent thread pool. Some circular dependent works could cause deadlock. The current to way to get around this deadlock is to provide abundant number of threads. # Solution as titled Pull Request resolved: pytorch#26313 Differential Revision: D17405491 Pulled By: xush6528 fbshipit-source-id: a1d9b6a84db0371cd4b63328fa00f651c0808485
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Problem
If there is not enough number of thread in the RPC Agent thread pool. Some circular dependent works could cause deadlock.
The current to way to get around this deadlock is to provide abundant number of threads.
Solution
as titled
Differential Revision: D17405491