Skip to content

[ROCm] Enable basic GPU profiling capability on ROCm.#26300

Closed
iotamudelta wants to merge 1 commit intopytorch:masterfrom
iotamudelta:some_profiling
Closed

[ROCm] Enable basic GPU profiling capability on ROCm.#26300
iotamudelta wants to merge 1 commit intopytorch:masterfrom
iotamudelta:some_profiling

Conversation

@iotamudelta
Copy link
Copy Markdown
Contributor

Inserting markers using the nvtx-equivalent API is not supported yet.

Inserting markers using the nvtx-equivalent API is not supported yet.
@iotamudelta iotamudelta added module: rocm AMD GPU support for Pytorch open source labels Sep 16, 2019
@iotamudelta iotamudelta requested a review from bddppq September 16, 2019 18:22
@pytorchbot pytorchbot added caffe2 module: autograd Related to torch.autograd, and the autograd engine in general module: build Build system issues labels Sep 16, 2019
@bddppq
Copy link
Copy Markdown
Contributor

bddppq commented Sep 17, 2019

I think we can remove these lines as well? https://github.com/pytorch/pytorch/blob/fc36842/tools/amd_build/build_amd.py#L113-L119

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@iotamudelta
Copy link
Copy Markdown
Contributor Author

@bddppq good point, I'll make that change in a follow-up once this here has landed.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@bddppq merged this pull request in 9181b9c.

@iotamudelta iotamudelta deleted the some_profiling branch October 8, 2019 18:31
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Inserting markers using the nvtx-equivalent API is not supported yet.
Pull Request resolved: pytorch#26300

Differential Revision: D17425573

Pulled By: bddppq

fbshipit-source-id: 4df6c695ba07ab68e7f4dc2f77edde06f78fdac7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

caffe2 Merged module: autograd Related to torch.autograd, and the autograd engine in general module: build Build system issues module: rocm AMD GPU support for Pytorch open source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants