[UNSTACK] Replace simple if_true / if_false cases in Declarations.cwrap.#26285
Closed
gchanan wants to merge 1 commit intogh/gchanan/84/basefrom
Closed
[UNSTACK] Replace simple if_true / if_false cases in Declarations.cwrap.#26285gchanan wants to merge 1 commit intogh/gchanan/84/basefrom
gchanan wants to merge 1 commit intogh/gchanan/84/basefrom
Conversation
I renamed: THTensor_(std / var) -> THTensor(std_single / var_single) THTensor(stdall / varall) -> THTensor(std_all, var_all) because I reversed the meaning of the bias/unbiased parameters (to match ATen) and type checking wouldn't catch failures.
gchanan
added a commit
that referenced
this pull request
Sep 16, 2019
I renamed: THTensor_(std / var) -> THTensor(std_single / var_single) THTensor(stdall / varall) -> THTensor(std_all, var_all) because I reversed the meaning of the bias/unbiased parameters (to match ATen) and type checking wouldn't catch failures. ghstack-source-id: ad17f35 Pull Request resolved: #26285
Contributor
Author
|
Same as #25614. |
zou3519
approved these changes
Sep 16, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 17, 2019
Summary: Pull Request resolved: pytorch/pytorch#26285 I renamed: THTensor_(std / var) -> THTensor(std_single / var_single) THTensor(stdall / varall) -> THTensor(std_all, var_all) because I reversed the meaning of the bias/unbiased parameters (to match ATen) and type checking wouldn't catch failures. Test Plan: Imported from OSS Differential Revision: D17397227 Pulled By: gchanan fbshipit-source-id: 244fe878d4e1045620137c00fbaea6e6f919fc8d
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ch#26285) Summary: Pull Request resolved: pytorch#26285 I renamed: THTensor_(std / var) -> THTensor(std_single / var_single) THTensor(stdall / varall) -> THTensor(std_all, var_all) because I reversed the meaning of the bias/unbiased parameters (to match ATen) and type checking wouldn't catch failures. Test Plan: Imported from OSS Differential Revision: D17397227 Pulled By: gchanan fbshipit-source-id: 244fe878d4e1045620137c00fbaea6e6f919fc8d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
I renamed:
THTensor_(std / var) -> THTensor(std_single / var_single)
THTensor(stdall / varall) -> THTensor(std_all, var_all)
because I reversed the meaning of the bias/unbiased parameters (to match ATen) and type checking wouldn't catch failures.
Differential Revision: D17397227