Support unpickle py2 NetDef object in py3#26147
Closed
xw285cornell wants to merge 1 commit intopytorch:masterfrom
Closed
Support unpickle py2 NetDef object in py3#26147xw285cornell wants to merge 1 commit intopytorch:masterfrom
xw285cornell wants to merge 1 commit intopytorch:masterfrom
Conversation
02613a8 to
0b89ac9
Compare
0b89ac9 to
ffeb623
Compare
ffeb623 to
0a39e1d
Compare
0a39e1d to
979d1b8
Compare
Contributor
Author
|
@pytorchbot retest this please |
979d1b8 to
a6ae238
Compare
Summary: Pull Request resolved: pytorch#26147 We may try to unpickle a byte string in py3 that was pickled from py2. Therefore we need to add encoding latin1. Reviewed By: kennyhorror Differential Revision: D17305677 fbshipit-source-id: 3116f3098d1d8fe917d8a17f70fbb57579ec66ae
a6ae238 to
1b48531
Compare
Contributor
|
This pull request has been merged in f341291. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#26147 We may try to unpickle a byte string in py3 that was pickled from py2. Therefore we need to add encoding latin1. Reviewed By: kennyhorror Differential Revision: D17305677 fbshipit-source-id: c0c8a51909629a65eb72bb81cccfbabaee9f8d01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: We may try to unpickle a byte string in py3 that was pickled from py2. Therefore we need to add encoding latin1.
Reviewed By: kennyhorror
Differential Revision: D17305677