Skip to content

Enable batching for pinverse#26095

Closed
vishwakftw wants to merge 4 commits intopytorch:masterfrom
vishwakftw:pinverse-batched
Closed

Enable batching for pinverse#26095
vishwakftw wants to merge 4 commits intopytorch:masterfrom
vishwakftw:pinverse-batched

Conversation

@vishwakftw
Copy link
Copy Markdown
Contributor

Changelog:

  • Modify existing implementation of pinverse to support batching on inputs

Test Plan:

  • Added tests in test_pinverse to test batched implementation

Changelog:
- Modify existing implementation of pinverse to support batching on inputs

Test Plan:
- Added tests in test_pinverse to test batched implementation
@vishwakftw
Copy link
Copy Markdown
Contributor Author

@pytorchbot rebase this please

@soumith
Copy link
Copy Markdown
Collaborator

soumith commented Sep 16, 2019

has conflicts

@vishwakftw
Copy link
Copy Markdown
Contributor Author

Please allow me to fix them by evening, not sure what caused the conflict

@vishwakftw
Copy link
Copy Markdown
Contributor Author

@soumith I've fixed the conflicts, thank you for letting me know about the same.

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Sep 17, 2019
Summary:
Changelog:
- Modify existing implementation of pinverse to support batching on inputs
Pull Request resolved: pytorch/pytorch#26095

Test Plan: - Added tests in test_pinverse to test batched implementation

Differential Revision: D17408092

Pulled By: soumith

fbshipit-source-id: bba95eb193ce33a94ecfaf74da270d34b435e4af
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@soumith merged this pull request in 2dac673.

@vishwakftw vishwakftw deleted the pinverse-batched branch September 22, 2019 17:54
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Changelog:
- Modify existing implementation of pinverse to support batching on inputs
Pull Request resolved: pytorch#26095

Test Plan: - Added tests in test_pinverse to test batched implementation

Differential Revision: D17408092

Pulled By: soumith

fbshipit-source-id: bba95eb193ce33a94ecfaf74da270d34b435e4af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants