Add a float version of calc_erfinv (by templating) on CPU#26070
Closed
xuhdev wants to merge 2 commits intopytorch:masterfrom
Closed
Add a float version of calc_erfinv (by templating) on CPU#26070xuhdev wants to merge 2 commits intopytorch:masterfrom
xuhdev wants to merge 2 commits intopytorch:masterfrom
Conversation
Currently calc_erfinv's float version on CPU is missing. This commit add the float version. I also used this opportunity to clean up calc_erfinv a bit.
Collaborator
Author
|
@pytorchbot rebase this please |
VitalyFedyunin
approved these changes
Sep 13, 2019
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
Author
|
@pytorchbot merge this please |
Contributor
Aaaa! Magic! |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 18, 2019
Summary: Currently calc_erfinv's float version on CPU is missing. This commit adds the float version (by templating). I also used this opportunity to clean up calc_erfinv a bit. Pull Request resolved: pytorch/pytorch#26070 Reviewed By: ezyang Differential Revision: D17368024 Pulled By: VitalyFedyunin fbshipit-source-id: 00cc3097f340022b3788143e6c12b01c35d72f13
Contributor
|
@VitalyFedyunin merged this pull request in 2801df5. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
) Summary: Currently calc_erfinv's float version on CPU is missing. This commit adds the float version (by templating). I also used this opportunity to clean up calc_erfinv a bit. Pull Request resolved: pytorch#26070 Reviewed By: ezyang Differential Revision: D17368024 Pulled By: VitalyFedyunin fbshipit-source-id: 00cc3097f340022b3788143e6c12b01c35d72f13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently calc_erfinv's float version on CPU is missing. This commit adds the float version (by templating).
I also used this opportunity to clean up calc_erfinv a bit.