[jit] Refactor emitIsInstance#26061
Closed
zdevito wants to merge 5 commits intogh/zdevito/106/basefrom
Closed
Conversation
This is in preparation for actually emitting a dynamic isinstance check instruction. It re-arranges the logic so that all the types and properties to check against are in a flat list. In the future this flat list will be encoded into an actual instruction if we determine that we cannot perform the check statically.
This was referenced Sep 11, 2019
[jit] Refactor emitIsInstance This is in preparation for actually emitting a dynamic isinstance check instruction. It re-arranges the logic so that all the types and properties to check against are in a flat list. In the future this flat list will be encoded into an actual instruction if we determine that we cannot perform the check statically. gh-metadata: pytorch pytorch 26061 gh/zdevito/106/head
[jit] Refactor emitIsInstance This is in preparation for actually emitting a dynamic isinstance check instruction. It re-arranges the logic so that all the types and properties to check against are in a flat list. In the future this flat list will be encoded into an actual instruction if we determine that we cannot perform the check statically. gh-metadata: pytorch pytorch 26061 gh/zdevito/106/head
[jit] Refactor emitIsInstance This is in preparation for actually emitting a dynamic isinstance check instruction. It re-arranges the logic so that all the types and properties to check against are in a flat list. In the future this flat list will be encoded into an actual instruction if we determine that we cannot perform the check statically. gh-metadata: pytorch pytorch 26061 gh/zdevito/106/head
suo
approved these changes
Sep 18, 2019
[jit] Refactor emitIsInstance This is in preparation for actually emitting a dynamic isinstance check instruction. It re-arranges the logic so that all the types and properties to check against are in a flat list. In the future this flat list will be encoded into an actual instruction if we determine that we cannot perform the check statically. gh-metadata: pytorch pytorch 26061 gh/zdevito/106/head
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This is in preparation for actually emitting a dynamic isinstance check instruction.
It re-arranges the logic so that all the types and properties to check
against are in a flat list. In the future this flat list will be encoded
into an actual instruction if we determine that we cannot perform
the check statically.
Differential Revision: D17332062