Skip to content

[ROCm] enable unit tests#25963

Closed
iotamudelta wants to merge 8 commits intopytorch:masterfrom
iotamudelta:enable_tests_20190910
Closed

[ROCm] enable unit tests#25963
iotamudelta wants to merge 8 commits intopytorch:masterfrom
iotamudelta:enable_tests_20190910

Conversation

@iotamudelta
Copy link
Copy Markdown
Contributor

@iotamudelta iotamudelta commented Sep 10, 2019

These unit tests pass after landing all the warp size awareness patches.

@iotamudelta iotamudelta added module: rocm AMD GPU support for Pytorch open source labels Sep 10, 2019
@iotamudelta iotamudelta requested a review from bddppq September 10, 2019 23:31
@pytorchbot pytorchbot added oncall: jit Add this issue/PR to JIT oncall triage queue module: cuda Related to torch.cuda, and CUDA support in general module: nn Related to torch.nn module: optimizer Related to torch.optim labels Sep 10, 2019
@bddppq
Copy link
Copy Markdown
Contributor

bddppq commented Sep 11, 2019

Lint failure is real:

./test/test_optim.py:17:1: F401 'common_utils.skipIfRocm' imported but unused

But it's good news that it means there is no more rocm skipped test in that file :-)

@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 11, 2019
@iotamudelta
Copy link
Copy Markdown
Contributor Author

iotamudelta commented Sep 11, 2019

@bddppq just fixed - indeed test_optim doesn't require importing skipIfRocm any longer. :-)

@bddppq
Copy link
Copy Markdown
Contributor

bddppq commented Sep 11, 2019

@pytorchbot retest this please

facebook-github-bot
facebook-github-bot reviewed Sep 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

bddppq
bddppq approved these changes Sep 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@bddppq bddppq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 11, 2019

@bddppq merged this pull request in 00d967c.

@iotamudelta iotamudelta deleted the enable_tests_20190910 branch September 11, 2019 21:39
@bddppq bddppq mentioned this pull request Sep 18, 2019
Closed
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@iotamudelta @facebook-github-bot
enable unit tests (pytorch#25963)
8744c92 
Summary:
These unit tests pass after landing all the warp size awareness patches.
Pull Request resolved: pytorch#25963

Differential Revision: D17319124

Pulled By: bddppq

fbshipit-source-id: 22f5d5f1ca9c67e66a7ccf983b2d2f889a74e729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@bddppq bddppq bddppq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: cuda Related to torch.cuda, and CUDA support in general module: nn Related to torch.nn module: optimizer Related to torch.optim module: rocm AMD GPU support for Pytorch oncall: jit Add this issue/PR to JIT oncall triage queue open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iotamudelta @bddppq @facebook-github-bot @jerryzh168 @pytorchbot @mruberry