Remove unnecessary BUILD_NAMEDTENSOR from interned_strings.h#25938
Closed
zou3519 wants to merge 2 commits intogh/zou3519/163/basefrom
Closed
Remove unnecessary BUILD_NAMEDTENSOR from interned_strings.h#25938zou3519 wants to merge 2 commits intogh/zou3519/163/basefrom
zou3519 wants to merge 2 commits intogh/zou3519/163/basefrom
Conversation
It doesn't matter whether or not we expose these for namedtensor / non-namedtensor builds. Test Plan: - [namedtensor ci]
This was referenced Sep 10, 2019
It doesn't matter whether or not we expose these for namedtensor / non-namedtensor builds. Test Plan: - [namedtensor ci] Differential Revision: [D17291249](https://our.internmc.facebook.com/intern/diff/D17291249)
This was referenced Sep 10, 2019
nairbv
approved these changes
Sep 11, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 11, 2019
Summary: Pull Request resolved: pytorch/pytorch#25938 It doesn't matter whether or not we expose these for namedtensor / non-namedtensor builds. Test Plan: - [namedtensor ci] Differential Revision: D17291249 Pulled By: zou3519 fbshipit-source-id: a5aac77469e28198f63967396e2bdb1ec15bad97
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
It doesn't matter whether or not we expose these for namedtensor /
non-namedtensor builds.
Test Plan:
Pull Request resolved: #25938
Differential Revision: D17291249