Disable flaky test_invalid_names in test_rpc.py#25916
Closed
mrshenli wants to merge 1 commit intopytorch:masterfrom
Closed
Disable flaky test_invalid_names in test_rpc.py#25916mrshenli wants to merge 1 commit intopytorch:masterfrom
mrshenli wants to merge 1 commit intopytorch:masterfrom
Conversation
pietern
approved these changes
Sep 10, 2019
Contributor
|
What about the initialization/destruction order could make this segfault? |
Contributor
Author
|
I am not sure what happened here. The error was thrown from |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: pietern discovered that `test_invalid_names` is flaky on master. pytorch#25656 is potentially the fix. Disable this test for now and will try to add it again when pytorch#25656 is in. Pull Request resolved: pytorch#25916 Differential Revision: D17287496 Pulled By: mrshenli fbshipit-source-id: 9313958d3480c2bab20cd2341837c7821e3bb1b5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pietern discovered that
test_invalid_namesis flaky on master. #25656 is potentially the fix. Disable this test for now and will try to add it again when #25656 is in.