Skip to content

Kill defaults in nn.yaml.#25737

Closed
gchanan wants to merge 6 commits intogh/gchanan/79/basefrom
gh/gchanan/79/head
Closed

Kill defaults in nn.yaml.#25737
gchanan wants to merge 6 commits intogh/gchanan/79/basefrom
gh/gchanan/79/head

Conversation

@gchanan
Copy link
Contributor

@gchanan gchanan commented Sep 5, 2019

Stack from ghstack:

Since this isn't the end-user API anymore, we shouldn't have defaults.

Differential Revision: D17228153

Since this isn't the end-user API anymore, we shouldn't have defaults.
Since this isn't the end-user API anymore, we shouldn't have defaults.

Differential Revision: [D17228153](https://our.internmc.facebook.com/intern/diff/D17228153)
gchanan added a commit that referenced this pull request Sep 11, 2019
Since this isn't the end-user API anymore, we shouldn't have defaults.

ghstack-source-id: 9a3e245
Pull Request resolved: #25737
Since this isn't the end-user API anymore, we shouldn't have defaults.

Differential Revision: [D17228153](https://our.internmc.facebook.com/intern/diff/D17228153)
Since this isn't the end-user API anymore, we shouldn't have defaults.

Differential Revision: [D17228153](https://our.internmc.facebook.com/intern/diff/D17228153)
gchanan added a commit that referenced this pull request Sep 11, 2019
Since this isn't the end-user API anymore, we shouldn't have defaults.

ghstack-source-id: c5948d3
Pull Request resolved: #25737
Since this isn't the end-user API anymore, we shouldn't have defaults.

Differential Revision: [D17228153](https://our.internmc.facebook.com/intern/diff/D17228153)
gchanan added a commit that referenced this pull request Sep 12, 2019
Since this isn't the end-user API anymore, we shouldn't have defaults.

ghstack-source-id: d2674f5
Pull Request resolved: #25737
Since this isn't the end-user API anymore, we shouldn't have defaults.

Differential Revision: [D17228153](https://our.internmc.facebook.com/intern/diff/D17228153)
gchanan added a commit that referenced this pull request Sep 13, 2019
Since this isn't the end-user API anymore, we shouldn't have defaults.

ghstack-source-id: 46a3893
Pull Request resolved: #25737
@gchanan gchanan closed this Sep 16, 2019
@facebook-github-bot facebook-github-bot deleted the gh/gchanan/79/head branch October 28, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: internals Related to internal abstractions in c10 and ATen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants