Closed
Conversation
suo
approved these changes
Aug 29, 2019
| ${JIT_TEST_ROOT}/test_subgraph_utils.cpp | ||
| ${JIT_TEST_ROOT}/test_utils.cpp | ||
| ) | ||
| set(JIT_TEST_SRCS ${JIT_TEST_SRCS} PARENT_SCOPE) |
Member
There was a problem hiding this comment.
if you set PARENT_SCOPE above, this line is unnecessary
This was referenced Aug 30, 2019
Fix BUILD TEST gh-metadata: pytorch pytorch 25418 gh/zdevito/99/head
Fix BUILD TEST gh-metadata: pytorch pytorch 25418 gh/zdevito/99/head
Fix BUILD TEST gh-metadata: pytorch pytorch 25418 gh/zdevito/99/head
Fix BUILD TEST gh-metadata: pytorch pytorch 25418 gh/zdevito/99/head
Fix BUILD TEST gh-metadata: pytorch pytorch 25418 gh/zdevito/99/head
This was referenced Sep 11, 2019
Fix BUILD TEST gh-metadata: pytorch pytorch 25418 gh/zdevito/99/head
Collaborator
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIT_TEST_SRCS is used in libtorch_python.so even when BUILD_TEST is off, so we need to include the cmake file regardless of if we end up building the separate executable.
Stack from ghstack:
Differential Revision: D17119129