Enable broadcasting of batch dimensions RHS and LHS tensors for lu_solve#24333
Closed
vishwakftw wants to merge 15 commits intopytorch:masterfrom
Closed
Enable broadcasting of batch dimensions RHS and LHS tensors for lu_solve#24333vishwakftw wants to merge 15 commits intopytorch:masterfrom
vishwakftw wants to merge 15 commits intopytorch:masterfrom
Conversation
Changelog: - Enable broadcasting of RHS and LHS tensors for lu_solve. This means that you can now have RHS with size `3 x 2` and LHS with size `4 x 3 x 3` for instance - Remove deprecated behavior of having 2D tensors for RHS. Now all tensors have to have a last dimension which equals the number of right hand sides - Modified docs Test Plan: - Add tests for new behavior in test_torch.py with a port to test_cuda.py
Contributor
Author
|
@pytorchbot rebase this please |
14 tasks
Contributor
Author
|
@pytorchbot rebase this please |
zou3519
reviewed
Aug 19, 2019
Contributor
zou3519
left a comment
There was a problem hiding this comment.
Code looks correct. I had some comments on style and cleaning up the testing code
…olve-new-version
…into lu_solve-new-version
Contributor
Author
|
@zou3519 I actually missed out on adding tests for broadcasting behavior earlier. I've added them now, just FYI. |
Contributor
Author
|
@zou3519 except for test refactoring and specifying sizes in error message (which will be addressed in follow-up PRs), the PR should be good to review again. |
vishwakftw
commented
Aug 20, 2019
| return torch.stack(all_matrices).reshape(*(batches + (l, l))) | ||
|
|
||
|
|
||
| def random_linalg_solve_processed_inputs(A_dims, b_dims, gen_fn, transform_fn, cast_fn): |
Contributor
Author
There was a problem hiding this comment.
Once this PR is merged, I will use this function in other places in the test suite for *solve methods. This would reduce duplication of code.
Contributor
Author
|
@pytorchbot rebase this please |
zou3519
reviewed
Aug 22, 2019
Contributor
zou3519
left a comment
There was a problem hiding this comment.
Thank you, the code looks a lot better now :)
I had some last comments about repetitiveness in the testing code
…into lu_solve-new-version
…olve-new-version
Contributor
Author
|
@pytorchbot rebase this please |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 3, 2019
…lve (#24333) Summary: Changelog: - Enable broadcasting of RHS and LHS tensors for lu_solve. This means that you can now have RHS with size `3 x 2` and LHS with size `4 x 3 x 3` for instance - Remove deprecated behavior of having 2D tensors for RHS. Now all tensors have to have a last dimension which equals the number of right hand sides - Modified docs Pull Request resolved: pytorch/pytorch#24333 Test Plan: - Add tests for new behavior in test_torch.py with a port to test_cuda.py Differential Revision: D17165463 Pulled By: zou3519 fbshipit-source-id: cda5d5496ddb29ed0182bab250b5d90f8f454aa6
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 11, 2019
Summary: Changelog: - De-duplicate the code in tests for torch.solve, torch.cholesky_solve, torch.triangular_solve - Skip tests explicitly if requirements aren't met for e.g., if NumPy / SciPy aren't available in the environment - Add generic helpers for these tests in test/common_utils.py Pull Request resolved: #25733 Test Plan: - All tests should pass to confirm that the change is not erroneous Clears one point specified in the discussion in #24333. Differential Revision: D17315330 Pulled By: zou3519 fbshipit-source-id: c72a793e89af7e2cdb163521816d56747fd70a0e
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…lve (pytorch#24333) Summary: Changelog: - Enable broadcasting of RHS and LHS tensors for lu_solve. This means that you can now have RHS with size `3 x 2` and LHS with size `4 x 3 x 3` for instance - Remove deprecated behavior of having 2D tensors for RHS. Now all tensors have to have a last dimension which equals the number of right hand sides - Modified docs Pull Request resolved: pytorch#24333 Test Plan: - Add tests for new behavior in test_torch.py with a port to test_cuda.py Differential Revision: D17165463 Pulled By: zou3519 fbshipit-source-id: cda5d5496ddb29ed0182bab250b5d90f8f454aa6
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Changelog: - De-duplicate the code in tests for torch.solve, torch.cholesky_solve, torch.triangular_solve - Skip tests explicitly if requirements aren't met for e.g., if NumPy / SciPy aren't available in the environment - Add generic helpers for these tests in test/common_utils.py Pull Request resolved: pytorch#25733 Test Plan: - All tests should pass to confirm that the change is not erroneous Clears one point specified in the discussion in pytorch#24333. Differential Revision: D17315330 Pulled By: zou3519 fbshipit-source-id: c72a793e89af7e2cdb163521816d56747fd70a0e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog:
3 x 2and LHS with size4 x 3 x 3for instanceTest Plan: