Improve Windows Compatibility(for 0.2.0) by peterjc123 · Pull Request #2402 · pytorch/pytorch

peterjc123 · 2017-08-13T18:16:15Z

The code changes that helps build on Windows.

torch/lib/TH/THGeneral.c


-TH_API THDescBuff _THSizeDesc(const long *size, const long ndim) {
-  const int L = TH_DESC_BUFF_LEN;
+TH_API THDescBuff _THSizeDesc(const uint8_t *size, const uint8_t ndim) {


torch/lib/TH/generic/THTensorRandom.c

-  int i = 0, _mask=0;
+  int64_t K = THLongTensor_nElement(J);
+  int64_t output_nelem = THLongTensor_nElement(self);
+  int64_t i = 0, _mask=0;


torch/lib/TH/generic/THTensorRandom.c

      _q = THTensor_fastGet1d(q, rand_ind);

-      _mask = THRandom_bernoulli(_generator, _q);
+      _mask = (int) THRandom_bernoulli(_generator, _q);


torch/lib/TH/THAtomic.c

 #elif defined(USE_MSC_ATOMICS)
-  assert(sizeof(int) == sizeof(long));
-  return _InterlockedExchangeAdd((long*)a, value);
+  //assert(sizeof(int32_t) == sizeof(long));


fmassa · 2017-08-13T19:29:18Z

Thanks a lot for the PR!

I had a quick look at the TH changes.
Apart from the MappingAllocator part that I didn't follow much, the rest of the changes mostly consist of replacing long with int64_t, int with int32_t etc, and for that they also had to define ureal type in the macros, so that some bits of the code (that used unsigned real) can work.

Also, Travis is failing with a weird error message just before trying to checkout the branch:

$ git checkout -qf FETCH_HEAD

error: unable to create symlink tools/shared/cwrap_common.py: File name too long

peterjc123 · 2017-08-13T19:36:28Z

@fmassa The error is caused by that i changed that file from a symlink to the real copy of the file. Since it can be done through git config, i'll change it back.

fmassa · 2017-08-13T19:53:43Z

Ok, now I got it.
This file was changed and now is causing the issue. I didn't look closely, but why did you need to change it from what it was before?

peterjc123 · 2017-08-13T19:56:13Z

@fmassa Symlinks don't work on Windows on default. I'll change it back later.

gchanan · 2017-08-14T17:06:45Z

I don't know if anything has been announced about this, but I think v.0.2.0 should only have bug fixes, not new feature; this is a new feature.

torch/csrc/THP.h

+# ifdef _WIN32
+#  define PyInt_FromLong        PyLong_FromLongLong
+# else
+#  define PyInt_FromLong        PyLong_FromLong


fmassa · 2017-08-14T17:23:44Z

@gchanan should he then target merging into master, and not v0.2.0?

…7f62f5 (pytorch#29363) Summary: Pull Request resolved: pytorch#29363 Previous import was 2891e1459745933f4bba9a8cb3371cf3c9eb1d16 Included changes: - **[fea8568c](onnx/onnx@fea8568c)**: minor changes to NonZero and Slice (pytorch#2429) <Ashwini Khade> - **[79bd5042](onnx/onnx@79bd5042)**: fix test bugs for resize op version 11 (pytorch#2425) <Ashwini Khade> - **[3ea3b0e0](onnx/onnx@3ea3b0e0)**: Add shape existence check in GatherElements shape inference logic (pytorch#2402) <Hariharan Seshadri> - **[192ad8c8](onnx/onnx@192ad8c8)**: add invite for next workshop (pytorch#2407) <Prasanth Pulavarthi> - **[eea60812](onnx/onnx@eea60812)**: Fix missing comma in exception message. Causes invalid message depending on what's in memory prior to the constant char string. (pytorch#2403) <Scott McKay> - **[dd082c99](onnx/onnx@dd082c99)**: Add section headers for easier linking (pytorch#2400) <Prasanth Pulavarthi> - **[ca1d5b7e](onnx/onnx@ca1d5b7e)**: Add type check for node inputs (pytorch#2367) <RandySheriffH> - **[e5600091](onnx/onnx@e5600091)**: Update doc loop op (pytorch#2337) <G. Ramalingam> Test Plan: ci Reviewed By: hl475 Differential Revision: D18365923 fbshipit-source-id: 29aedd36020db633a946a97bf7d22d9f27f82f09

…7f62f5 (#29363) Summary: Pull Request resolved: #29363 Previous import was 2891e1459745933f4bba9a8cb3371cf3c9eb1d16 Included changes: - **[fea8568c](onnx/onnx@fea8568c)**: minor changes to NonZero and Slice (#2429) <Ashwini Khade> - **[79bd5042](onnx/onnx@79bd5042)**: fix test bugs for resize op version 11 (#2425) <Ashwini Khade> - **[3ea3b0e0](onnx/onnx@3ea3b0e0)**: Add shape existence check in GatherElements shape inference logic (#2402) <Hariharan Seshadri> - **[192ad8c8](onnx/onnx@192ad8c8)**: add invite for next workshop (#2407) <Prasanth Pulavarthi> - **[eea60812](onnx/onnx@eea60812)**: Fix missing comma in exception message. Causes invalid message depending on what's in memory prior to the constant char string. (#2403) <Scott McKay> - **[dd082c99](onnx/onnx@dd082c99)**: Add section headers for easier linking (#2400) <Prasanth Pulavarthi> - **[ca1d5b7e](onnx/onnx@ca1d5b7e)**: Add type check for node inputs (#2367) <RandySheriffH> - **[e5600091](onnx/onnx@e5600091)**: Update doc loop op (#2337) <G. Ramalingam> Test Plan: ci Reviewed By: hl475 Differential Revision: D18365923 fbshipit-source-id: 8ac138e3ff9d4fbc5fdf85d06785190334c346a1

…torch#2402) Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com>

TestItOnlyOnce and others added 18 commits August 12, 2017 13:00

Win64 README and .gitignore

22f4c50

Win64 support for lib/TH

308271b

Win64 support for libshm

b7e00c7

Win64 support for build and test files

03f09dc

Win64 support for Python scripts

78c76a7

Win64 support for lib/nccl

0d3390f

Win64 support for lib/THPP

e4528c4

Win64 support for .cwrap files

bfe8013

Win64 support for FindCUDA.cmake

04eb58c

Win64 support for csrc

7830f71

Win64 support for lib/ATen

de35219

Win64 support for lib/THC

71e2eb8

Win64 support for lib/THCS

da63cb7

Win64 support for lib/THCUNN

fb14c9d

Win64 support for lib/THD

e56fac4

Win64 support for lib/THNN

2ae5962

Win64 support for lib/THS

ad17a12

Fixed some bugs that prevent build failure on Windows

a4fc05a

peterjc123 changed the title ~~Improve Windows Compatibility(based on Pytorch 0.2.0)~~ Improve Windows Compatibility(for Pytorch 0.2.0) Aug 13, 2017

peterjc123 changed the title ~~Improve Windows Compatibility(for Pytorch 0.2.0)~~ Improve Windows Compatibility(for 0.2.0) Aug 13, 2017

peterjc123 mentioned this pull request Aug 13, 2017

Add windows support please #494

Closed

unquote build_all_cmd

a94f3e6

fmassa reviewed Aug 13, 2017

View reviewed changes

torch/lib/TH/generic/THTensorRandom.c

int i = 0, _mask=0;

int64_t K = THLongTensor_nElement(J);

int64_t output_nelem = THLongTensor_nElement(self);

int64_t i = 0, _mask=0;

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

fmassa reviewed Aug 13, 2017

View reviewed changes

torch/lib/TH/generic/THTensorRandom.c

_q = THTensor_fastGet1d(q, rand_ind);

_mask = THRandom_bernoulli(_generator, _q);

_mask = (int) THRandom_bernoulli(_generator, _q);

This comment was marked as off-topic.

Sign in to view

fmassa reviewed Aug 13, 2017

View reviewed changes

torch/lib/TH/THAtomic.c

#elif defined(USE_MSC_ATOMICS)

assert(sizeof(int) == sizeof(long));

return _InterlockedExchangeAdd((long*)a, value);

//assert(sizeof(int32_t) == sizeof(long));

This comment was marked as off-topic.

Sign in to view

peterjc123 mentioned this pull request Aug 13, 2017

Improve Windows Compatibility #1786

Closed

peterjc123 added 6 commits August 14, 2017 12:31

Revert changes on cwrap_common.py

01f2fb7

Fixed nvtoolext.py for linux/mac

68a713e

Fixed gen.py for linux/mac

9b240de

Fixed THD build failure on Linux/Mac

f982772

Add if-condition for Python3 and GCC

04c5d4d

Code formatting

cab8028

fmassa reviewed Aug 14, 2017

View reviewed changes

soumith closed this Aug 23, 2017

zou3519 pushed a commit to zou3519/pytorch that referenced this pull request Mar 30, 2018

Bump onnx opset version (pytorch#2402)

425361a

ezyang added the open source label Jun 24, 2019

houseroad mentioned this pull request Nov 7, 2019

Automatic update of fbcode/onnx to fea8568cac61a482ed208748fdc0e1a8e47f62f5 #29363

Closed

samnordmann pushed a commit to samnordmann/pytorch that referenced this pull request Mar 6, 2023

Add FusionExecutor::disassembledBinary (pytorch#2402)

84a0c36

jagadish-amd added a commit to jagadish-amd/pytorch that referenced this pull request Aug 1, 2025

[release/2.7] mx fp8: Skip test_blockwise_mxfloat8_error_messages (py…

601119d

…torch#2402) Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com>

Conversation

peterjc123 commented Aug 13, 2017

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

fmassa commented Aug 13, 2017

Uh oh!

peterjc123 commented Aug 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmassa commented Aug 13, 2017

Uh oh!

peterjc123 commented Aug 13, 2017

Uh oh!

gchanan commented Aug 14, 2017

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

fmassa commented Aug 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

peterjc123 commented Aug 13, 2017 •

edited

Loading