Conversation
added 6 commits
July 23, 2019 17:22
|
What is a tensor table? doesn't pickle just pickle to a blob and unpickle just reads from a blob? |
mrshenli
approved these changes
Aug 9, 2019
Contributor
mrshenli
left a comment
There was a problem hiding this comment.
RPC related changes look great! Thanks!
| values.size()); | ||
| return ScriptRet(std::move(values.front())); | ||
| auto value = jit::unpickle(payload, payload_size, &message.tensors()); | ||
| return ScriptRet(std::move(value)); |
Contributor
There was a problem hiding this comment.
nit: can we avoid creating an auto value by moving jit::unpickle to the constructor?
Contributor
yf225
pushed a commit
to yf225/pytorch
that referenced
this pull request
Aug 11, 2019
This reverts commit 01d98c7.
added 2 commits
August 12, 2019 11:37
driazati
pushed a commit
that referenced
this pull request
Aug 13, 2019
This was accidentally removed in #23241
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 13, 2019
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: This PR adds functions to wrap the Pickler and exposes them to the C++ API ](https://our.intern.facebook.com/intern/diff/16675418/) Pull Request resolved: pytorch#23241 Pulled By: driazati Differential Revision: D16675418 fbshipit-source-id: 76543c81ac67c3e20a75ebc2073191bcbd6573bf
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: This PR adds functions to wrap the Pickler and exposes them to the C++ API ](https://our.intern.facebook.com/intern/diff/16746451/) Pull Request resolved: pytorch#23241 Pulled By: driazati Differential Revision: D16746451 fbshipit-source-id: 25ea5db4174006ce41e2e8989c8a345b82f637a7
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: This was accidentally removed in pytorch#23241 Pull Request resolved: pytorch#24255 Pulled By: driazati Differential Revision: D16788490 fbshipit-source-id: 9465570ade0299a845ec1b51cf88efe9c49b439b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functions to wrap the Pickler and exposes them to the C++ API
Differential Revision: D16746451