Add Implicit Padding for 3D average pooling#2291
Closed
houseroad wants to merge 1 commit intopytorch:masterfrom
Closed
Add Implicit Padding for 3D average pooling#2291houseroad wants to merge 1 commit intopytorch:masterfrom
houseroad wants to merge 1 commit intopytorch:masterfrom
Conversation
soumith
approved these changes
Aug 25, 2017
Collaborator
|
this is now merged into master. thanks a lot @houseroad ! |
zou3519
pushed a commit
to zou3519/pytorch
that referenced
this pull request
Mar 30, 2018
houseroad
added a commit
to houseroad/pytorch
that referenced
this pull request
Sep 19, 2019
…66d486 (pytorch#26441) Summary: Pull Request resolved: pytorch#26441 Previous import was 1316afc9f972f81340faa05763e2898f38bcc3b0 Included changes: - **[23bb6ea1](onnx/onnx@23bb6ea1)**: Gemm optional bias (pytorch#2330) <James Allingham> - **[1ac1f219](onnx/onnx@1ac1f219)**: Changes for AIX platform (pytorch#1913) <kavanabhat> - **[13b026f5](onnx/onnx@13b026f5)**: Updated test cases for reshape (pytorch#2127) <James Allingham> - **[97fcfe30](onnx/onnx@97fcfe30)**: Replace is by == (pytorch#2326) <G. Ramalingam> - **[3b5601e6](onnx/onnx@3b5601e6)**: Updated docs for strides and dilations attributes (pytorch#2291) <James Allingham> - **[d0c697b1](onnx/onnx@d0c697b1)**: Revamped test cases for Gemm (pytorch#2060) <James Allingham> - **[a3955c3c](onnx/onnx@a3955c3c)**: Add more shape inference tests for Logical operators to improve coverage (pytorch#2133) <Hariharan Seshadri> - **[e2e12d97](onnx/onnx@e2e12d97)**: Change incorrect use of ValueError to TypeError (pytorch#2304) <prcvih> - **[1f4b5f8c](onnx/onnx@1f4b5f8c)**: Support dynamic 'pads' and 'value' in Pad operator (pytorch#2031) <Hariharan Seshadri> Test Plan: ci Differential Revision: D17466717 fbshipit-source-id: cf62916a92cf457adcc53c48f40f0d18cd11e034
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 24, 2019
…66d486 (#26441) Summary: Pull Request resolved: #26441 Previous import was 1316afc9f972f81340faa05763e2898f38bcc3b0 Included changes: - **[23bb6ea1](onnx/onnx@23bb6ea1)**: Gemm optional bias (#2330) <James Allingham> - **[1ac1f219](onnx/onnx@1ac1f219)**: Changes for AIX platform (#1913) <kavanabhat> - **[13b026f5](onnx/onnx@13b026f5)**: Updated test cases for reshape (#2127) <James Allingham> - **[97fcfe30](onnx/onnx@97fcfe30)**: Replace is by == (#2326) <G. Ramalingam> - **[3b5601e6](onnx/onnx@3b5601e6)**: Updated docs for strides and dilations attributes (#2291) <James Allingham> - **[d0c697b1](onnx/onnx@d0c697b1)**: Revamped test cases for Gemm (#2060) <James Allingham> - **[a3955c3c](onnx/onnx@a3955c3c)**: Add more shape inference tests for Logical operators to improve coverage (#2133) <Hariharan Seshadri> - **[e2e12d97](onnx/onnx@e2e12d97)**: Change incorrect use of ValueError to TypeError (#2304) <prcvih> - **[1f4b5f8c](onnx/onnx@1f4b5f8c)**: Support dynamic 'pads' and 'value' in Pad operator (#2031) <Hariharan Seshadri> Test Plan: ci Reviewed By: hl475 Differential Revision: D17466717 fbshipit-source-id: 0f89a7a5a821d2c693492c99b4bebd5966e21d9f
rraminen
pushed a commit
to rraminen/pytorch
that referenced
this pull request
Jul 9, 2025
…rch#2291) cherry-pick of pytorch@085f270 in rocm/pytorch:release/2.7 Co-authored-by: Doru Bercea, Glen Cao <glen.cao@amd.com>
rraminen
pushed a commit
to rraminen/pytorch
that referenced
this pull request
Aug 7, 2025
…rch#2291) cherry-pick of pytorch@085f270 in rocm/pytorch:release/2.7 Co-authored-by: Doru Bercea, Glen Cao <glen.cao@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add implicit zero padding in module AvgPool3d.
Interface change:
AvgPool3d(kernel_size, stride) ==> AvgPool3d(kernel_size, stride[, padding, ceil_mode, count_include_pad])
Test:
Add 4 test cases in test/test_nn.py.
Manually check the results of small input.
Manually test with large input.
Additional change:
The existing test cases work fine. No additional change is needed.