Add sanity checks for NCCL detection.#22819
Closed
xuhdev wants to merge 8 commits intogh/xuhdev/14/basefrom
Closed
Add sanity checks for NCCL detection.#22819xuhdev wants to merge 8 commits intogh/xuhdev/14/basefrom
xuhdev wants to merge 8 commits intogh/xuhdev/14/basefrom
Conversation
This was referenced Jul 12, 2019
Add sanity checks for NCCL detection. gh-metadata: pytorch pytorch 22819 gh/xuhdev/14/head
Add sanity checks for NCCL detection. gh-metadata: pytorch pytorch 22819 gh/xuhdev/14/head
ezyang
approved these changes
Jul 15, 2019
Contributor
ezyang
left a comment
There was a problem hiding this comment.
Thank you, this is lovely.
Add sanity checks for NCCL detection. gh-metadata: pytorch pytorch 22819 gh/xuhdev/14/head
Add sanity checks for NCCL detection. gh-metadata: pytorch pytorch 22819 gh/xuhdev/14/head
Add sanity checks for NCCL detection. gh-metadata: pytorch pytorch 22819 gh/xuhdev/14/head
Add sanity checks for NCCL detection. gh-metadata: pytorch pytorch 22819 gh/xuhdev/14/head
Add sanity checks for NCCL detection. gh-metadata: pytorch pytorch 22819 gh/xuhdev/14/head
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 16, 2019
Summary: Pull Request resolved: #22819 Test Plan: Imported from OSS Differential Revision: D16283037 Pulled By: ezyang fbshipit-source-id: fc09c9443a568d9af1c78a847282a7d707c49dd6
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 16, 2019
Summary: Pull Request resolved: pytorch/pytorch#22819 Test Plan: Imported from OSS Differential Revision: D16281714 Pulled By: ezyang fbshipit-source-id: 396bcbf099bd07b996cf779c6b43092096b52d90
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 16, 2019
Summary: Pull Request resolved: pytorch/pytorch#22819 Test Plan: Imported from OSS Differential Revision: D16283037 Pulled By: ezyang fbshipit-source-id: fc09c9443a568d9af1c78a847282a7d707c49dd6
Contributor
|
This is breaking master CUDA builds with (Example: https://circleci.com/gh/pytorch/pytorch/2204593?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link/console) |
Collaborator
Author
|
I think this should be merged only after #22818 is merged. |
Contributor
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Check whether NCCL header files and libraries have the same NCCL version number.
Differential Revision: D16283037