Closed
Conversation
4b8b4fd to
2a5ef0f
Compare
Contributor
Author
|
Rebased and force pushed to resolve conflict. |
Contributor
Author
|
Thanks for the stamp, @apaszke, and of course your work on THD. We wouldn't have been where we are today without it. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@pietern has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@pietern has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
It's been ~9 months since moving THD to the torch.distributed.deprecated namespace (see pytorch#11405) and we haven't seen issues related to it, so it's time to remove it. Closes pytorch#18967.
mrshenli
approved these changes
Jun 25, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 25, 2019
Summary: It's been ~9 months since moving THD to the `torch.distributed.deprecated` namespace (see pytorch/pytorch#11405) and we haven't seen issues related to it, so it's time to remove it. Closes pytorch/pytorch#18967. Pull Request resolved: pytorch/pytorch#22065 Reviewed By: mrshenli Differential Revision: D15983669 Pulled By: pietern fbshipit-source-id: 2a2f5866f9a63040bc7cef3956d5fd215aba7165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been ~9 months since moving THD to the
torch.distributed.deprecatednamespace (see #11405) and we haven't seen issues related to it, so it's time to remove it.Closes #18967.