make keepdim backcompat warnings emit in autograd as well#2157
Merged
make keepdim backcompat warnings emit in autograd as well#2157
Conversation
gchanan
reviewed
Jul 20, 2017
| keepdim_check(torch.min) | ||
| keepdim_check(torch.mode) | ||
| keepdim_check(torch.median) | ||
| keepdim_check(torch.kthvalue) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| mean_expanded = mean.expand_as(self) | ||
| zero_centered = self.sub(mean_expanded) | ||
| var = zero_centered.mul(zero_centered).sum(dim, keepdim) | ||
| var = zero_centered.mul(zero_centered).sum(dim, keepdim=keepdim_) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
houseroad
added a commit
to houseroad/pytorch
that referenced
this pull request
Jul 17, 2019
…22d5dd Summary: Previous import was 806aa863020fa180e57f576cb032ec44ce8ddcca Included changes: - **[70706498](onnx/onnx@70706498)**: TensorProto::INT8 & INT16 were missed here (pytorch#2164) <ZINEKS> - **[8218a4ea](onnx/onnx@8218a4ea)**: Fix LabelEncoder's shape inference (pytorch#2170) <Wei-Sheng Chin> - **[0f1a9a1c](onnx/onnx@0f1a9a1c)**: Fixing a unit test in Cumsum Operator (pytorch#2157) <Jeff Saremi> - **[2c03cff0](onnx/onnx@2c03cff0)**: [New Operator] CumSum (pytorch#2030) <Jeff Saremi> - **[220b8300](onnx/onnx@220b8300)**: Fix globalpool output shape (pytorch#2147) <daquexian> Differential Revision: D16341736 fbshipit-source-id: fcd136f20eadfd3a78ae2cd928a4d6eb7c709f4c
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 17, 2019
…22d5dd (#22981) Summary: Pull Request resolved: #22981 Previous import was 806aa863020fa180e57f576cb032ec44ce8ddcca Included changes: - **[70706498](onnx/onnx@70706498)**: TensorProto::INT8 & INT16 were missed here (#2164) <ZINEKS> - **[8218a4ea](onnx/onnx@8218a4ea)**: Fix LabelEncoder's shape inference (#2170) <Wei-Sheng Chin> - **[0f1a9a1c](onnx/onnx@0f1a9a1c)**: Fixing a unit test in Cumsum Operator (#2157) <Jeff Saremi> - **[2c03cff0](onnx/onnx@2c03cff0)**: [New Operator] CumSum (#2030) <Jeff Saremi> - **[220b8300](onnx/onnx@220b8300)**: Fix globalpool output shape (#2147) <daquexian> Reviewed By: benoitsteiner Differential Revision: D16341736 fbshipit-source-id: 7e7a2684d8c821991231bfd6558f9f6cb4fb05fb
xwang233
pushed a commit
to xwang233/pytorch
that referenced
this pull request
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keepdim backward compatibility warnings were silent in the context of
Variable. Fixed this.cc: @gchanan for review.